chore(cfn-property-mixins): exclude scripts/ from npm package#37227
Merged
mergify[bot] merged 2 commits intoMar 12, 2026
Merged
Conversation
aws-cdk-automation
previously requested changes
Mar 11, 2026
mrgrain
changed the title
scripts/ from npm package
aws-cdk-automation
dismissed stale reviews from themself
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
kumsmrit
approved these changes
Mar 12, 2026
aws-cdk-automation
removed
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
Contributor
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status🛑 Queue command has been cancelled |
Contributor
Author
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 54 minutes 40 seconds in the queue, including 43 minutes 45 seconds running CI. Required conditions to merge
|
…pts-from-npm-package
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
Bot
deleted the
mrgrain/fix/cfn-property-mixins/exclude-scripts-from-npm-package
branch
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
The
@aws-cdk/cfn-property-mixinspackage was recently graduated to a stable standalone package in #37215. During that work, thescripts/directory — which contains the code generation tooling (gen.ts,config.ts, and their compiled outputs) — was not added to.npmignore. These files are only needed at build time to generate the mixin source code and serve no purpose for consumers of the published package. Including them unnecessarily increases the package size on npm.Description of changes
Adds
scripts/to the.npmignorefile for@aws-cdk/cfn-property-mixins, matching the existing exclusion oftest/. This ensures the code generation scripts are stripped from the published tarball.Describe any new or updated permissions being added
No new permissions.
Description of how you validated changes
The
.npmignorefile already follows the same pattern fortest/. Thescripts/directory only contains build-time codegen files that are not referenced by any runtime code.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license