fix(elbv2): dropInvalidHeaderFields not reflected in CloudFormation when set to false#37373
Open
syukawa-gh wants to merge 1 commit intoaws:mainfrom
Open
fix(elbv2): dropInvalidHeaderFields not reflected in CloudFormation when set to false#37373syukawa-gh wants to merge 1 commit intoaws:mainfrom
dropInvalidHeaderFields not reflected in CloudFormation when set to false#37373syukawa-gh wants to merge 1 commit intoaws:mainfrom
Conversation
When `dropInvalidHeaderFields` is explicitly set to `false`, the attribute was omitted from the CloudFormation template because the condition `if (props.dropInvalidHeaderFields)` evaluates to false. Change the check to `!== undefined` so that both `true` and `false` values are included in the template. Closes aws#36409
github-actions
bot
added
beginning-contributor
Contributor
Author
|
Exemption Request: This PR fixes a one-line condition check and adds a unit test. Integration test is not applicable as this is a load balancer attribute change that doesn't affect CloudFormation resource structure. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
requested changes
Mar 27, 2026
Collaborator
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
When
dropInvalidHeaderFieldsis explicitly set tofalse, the attribute is omitted from the CloudFormation template. This prevents rolling back the setting fromtruetofalse.Closes #36409
Description of changes
Change
if (props.dropInvalidHeaderFields)toif (props.dropInvalidHeaderFields !== undefined)so that bothtrueandfalsevalues are included in the template, matching the pattern used byhttp2Enabled.Description of how you validated changes
Added a unit test that verifies the attribute is present in the template when set to
false.Checklist