feat(aws-cdk-lib): add s3FilesVolumeConfiguration to Volume#37742
Open
kench wants to merge 4 commits into
Open
feat(aws-cdk-lib): add s3FilesVolumeConfiguration to Volume#37742kench wants to merge 4 commits into
kench wants to merge 4 commits into
Conversation
github-actions
Bot
added
feature-request
github-actions
Bot
added
the
beginning-contributor
2 tasks
Add s3FilesVolumeConfiguration property to Volume to enable adding S3 Files volumes to ECS task definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #37741.
Reason for this change
CloudFormation L1 constructs exist for S3 Files support in ECS. This changes updates the L2 construct to support S3 Files volumes.
Description of changes
Added s3FilesVolumeConfiguration property to Volume input and updated supporting code to support populating the field on the L1 construct.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added new unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license