Skip to content

add support for mandoc#2635

Closed
ajacoutot wants to merge 2 commits intoaws:developfrom
d2si-oss:mandoc
Closed

add support for mandoc#2635
ajacoutot wants to merge 2 commits intoaws:developfrom
d2si-oss:mandoc

Conversation

@ajacoutot
Copy link

@ajacoutot ajacoutot commented Jun 4, 2017 •
edited by justindho
Loading

Issue #, if available:
#6918

Hi.

This will allow Linux distros and BSDs systems that use mandoc instead of groff to display 'help' without the need to install additional software. More information about the mandoc formatter is available at: http://mdocml.bsd.lv/
Thanks.

Antoine Jacoutot added 2 commits June 4, 2017 11:20
skip_if_windows: add BSDs to the non-skip list
b32310f
help: if groff is not found, try mandoc
81f2e1e 
This will allow 'help' to work on BSDs, Illumos and Linux
distributions using the mandoc formatter.
@JordonPhillips
Copy link
Member

JordonPhillips commented Jun 5, 2017

Could you please add tests? You can base yours off the existing tests for groff.

@ajacoutot
Copy link
Author

ajacoutot commented Jun 14, 2017

@JordonPhillips I missed these somehow... I've been a bit swamped lately but should be getting back to this soon. Thanks!

@ajacoutot
Copy link
Author

ajacoutot commented Jul 22, 2017

After a quick glance, I'm not sure where to add the tests. I don't get how to run the unit tests suite.

@joguSD
Copy link
Contributor

joguSD commented Jul 24, 2017

You should add the tests to the test_help.py file and the test suite can be run via nose.

@diehlaws diehlaws added feature-request A feature should be added or improved. and removed enhancement labels Jan 4, 2019
@justnance justnance added enhancement and removed feature-request A feature should be added or improved. labels Apr 15, 2019
@kdaily kdaily added feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. labels Sep 28, 2021
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
@wchengru
revert: aws#2697 s3-bucket are ignored with sam deploy --guided (aws#…
bc668a0 
…2635)

* fix: s3-bucket are ignored with sam deploy --guided

* remove unused import

* fix: include aws_lambda_builders package

* revert: aws#2697 s3-bucket are ignored with sam deploy --guided

* black format
@justindho justindho mentioned this pull request May 4, 2022
Closed
2 tasks
@tim-finnigan tim-finnigan linked an issue May 4, 2022 that may be closed by this pull request
Add support for mandoc #6918
Closed
2 tasks
@justindho
Copy link
Contributor

justindho commented May 9, 2022

Hi @ajacoutot, thanks for the PR. Our team just put out a contribution guide detailing improvements to the contribution process. I have created issue #6918 for this PR. We will wait for the issue to receive 10 upvotes before moving this PR into the ready-for-review stage on our project board. The rationale for this can be found in the rationale section of the contribution guide.

@justindho justindho marked this pull request as draft May 9, 2022 17:13
@justindho justindho removed the needs-review This issue or pull request needs review from a core team member. label May 20, 2022
@razamatan
Copy link

razamatan commented Nov 2, 2022

@justindho it's kinda ridiculous that you guys let this 6 line change languish for almost 5 years and didn't grandfather it in.

i applied this patch locally, and everything works as expected. it's very safe as it's not changing any core functionality, and strictly expanding options for man rendering.

@mattdeluco
Copy link

mattdeluco commented Nov 4, 2022

@justindho - aws cli is broken on macOS Ventura because groff is unavailable. Can you please take ownership here and squash this bug?

@razamatan
Copy link

razamatan commented Nov 4, 2022

btw, i went and created a couple prs off of #6918 to resolve merge conflicts on both the v1 (develop) and v2 branches.

@hssyoo hssyoo mentioned this pull request Nov 7, 2022
Merged
@tim-finnigan
Copy link
Contributor

tim-finnigan commented Apr 10, 2023

Thanks for creating this PR and for your patience - it looks like this has been implemented via #7413.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community enhancement feature-request A feature should be added or improved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for mandoc