Fix CMake (< v3.20) warning#2345
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
==========================================
- Coverage 78.77% 78.76% -0.01%
==========================================
Files 620 620
Lines 107954 107954
Branches 15336 15334 -2
==========================================
- Hits 85036 85033 -3
- Misses 22262 22263 +1
- Partials 656 658 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smittals2
approved these changes
Apr 21, 2025
andrewhop
approved these changes
Apr 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
fileinstead ofconfigure_filefor copying scripts.Callouts
FILE_PERMISSIONSoption forconfigure_fileis only available after v3.20. Older CMake versions produce the following warning:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.