Skip to content

Fix CMake (< v3.20) warning#2345

Merged
justsmth merged 1 commit into
aws:mainfrom
justsmth:fix-cmake-warning
Apr 22, 2025
Merged

Fix CMake (< v3.20) warning#2345
justsmth merged 1 commit into
aws:mainfrom
justsmth:fix-cmake-warning

Conversation

@justsmth

@justsmth justsmth commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

Description of changes:

  • Use file instead of configure_file for copying scripts.
    • Fixes warning output when using older CMake versions.

Callouts

CMake Warning (dev) at tool-openssl/CMakeLists.txt:50 (configure_file):
  configure_file called with unknown argument(s):

   FILE_PERMISSIONS
   OWNER_READ
   OWNER_WRITE
   OWNER_EXECUTE
   GROUP_READ
   GROUP_EXECUTE
   WORLD_READ
   WORLD_EXECUTE

This warning is for project developers.  Use -Wno-dev to suppress it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner April 21, 2025 20:54
@justsmth justsmth requested a review from smittals2 April 21, 2025 20:54
@codecov-commenter

codecov-commenter commented Apr 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.76%. Comparing base (a47a334) to head (f7920b4).
⚠️ Report is 578 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
- Coverage   78.77%   78.76%   -0.01%     
==========================================
  Files         620      620              
  Lines      107954   107954              
  Branches    15336    15334       -2     
==========================================
- Hits        85036    85033       -3     
- Misses      22262    22263       +1     
- Partials      656      658       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth merged commit 66f59c2 into aws:main Apr 22, 2025
@justsmth justsmth deleted the fix-cmake-warning branch April 22, 2025 12:24
@justsmth justsmth mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants