fix: add -J flag to tar for xz extraction in SDE Dockerfiles#3292
Open
dougch wants to merge 2 commits into
Open
fix: add -J flag to tar for xz extraction in SDE Dockerfiles#3292dougch wants to merge 2 commits into
dougch wants to merge 2 commits into
Conversation
tar on Amazon Linux 2 may not auto-detect xz compression. Explicitly pass -J to ensure .tar.xz extraction works.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
=======================================
Coverage 78.17% 78.17%
=======================================
Files 689 689
Lines 123732 123732
Branches 17199 17199
=======================================
+ Hits 96723 96725 +2
Misses 26089 26089
+ Partials 920 918 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
WillChilds-Klein
approved these changes
Jun 8, 2026
| # This emulator is needed when running BoringSSL/AWS-LC code under Intel's SDE for each supported chip (like ice lake). | ||
| # https://software.intel.com/content/www/us/en/develop/articles/intel-software-development-emulator.html#system-configuration | ||
| wget ${SDE_MIRROR_URL} && tar -xf "${SDE_VERSION_TAG}.tar.xz" && rm "${SDE_VERSION_TAG}.tar.xz" && \ | ||
| wget ${SDE_MIRROR_URL} && tar -xJf "${SDE_VERSION_TAG}.tar.xz" && rm "${SDE_VERSION_TAG}.tar.xz" && \ |
Contributor
There was a problem hiding this comment.
huh... does this mean our AL2 image builds have been broken for a while and we haven't noticed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves: n/a
Description of changes:
The SDE Dockerfiles extract a
.tar.xzarchive usingtar -xf, which relies on tar auto-detecting xz compression. On Amazon Linux 2, tar does not support auto-detection for xz — it requires the explicit-Jflag.Sample Failure
Fix:
tar -xf→tar -xJfCall-outs:
This will not run in PR CI — it only triggers on the image-build workflow.
It is unclear how long this has been broken — a version bump may introduce collateral failures.
Testing:
None —
man tarconfirms-Jis the correct flag for xz decompression.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.