Conversation
|
As some background for this change, inspector does not report end of execution (in Node 6.10) so the debugger never knows when to disconnect. This PR was made and merged for Node 7+ but never backported to Node 6.10. Because of this, IDEs can't know when the debugger should detach if they're using inspector for Node6.x or below. |
|
See also the official Node docs on debugging that mentions:
|
|
Lastly, it's worth noting that the previous change to inspector was prompted by a bug in VSCode. That bug has since been fixed (see comment from previous PR). |
sanathkr
left a comment
sanathkr
left a comment
There was a problem hiding this comment.
These changes make sense. I also pulled the PR locally, verified using VSCode that this fix works.
I also added a fix for Node8 to make debugging actually work
* Added Locking to Layer Building * Fixed LockChain Exception * Added Comment
2 participants
Issue #, if available:
Pertains to this comment made on this PR.
Description of changes:
Changes the run command for Node.js version 6.10 to use the legacy debugger (as it previously did) instead of the inspector debugger. Includes directions in the README for when to use legacy and when to use inspector in your launch configuration in VSCode.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.