Skip to content

feat: custom image name support for Docker builds#8382

Open
dtsulik wants to merge 5 commits intoaws:developfrom
dtsulik:feat/custom-image-name-for-docker-builds
Open

feat: custom image name support for Docker builds#8382
dtsulik wants to merge 5 commits intoaws:developfrom
dtsulik:feat/custom-image-name-for-docker-builds

Conversation

@dtsulik
Copy link
Copy Markdown

@dtsulik dtsulik commented Oct 30, 2025

Which issue(s) does this change fix?

N/A

Why is this change necessary?

Currently the Docker build takes the logical resource ID from the template as the name for the image that gets built and tagged. We are able to customize the tag, but not the name. This forces the same restrictions on the image name allowed characters as the resource ID, meaning we cannot use dashes.

How does it address the issue?

Allows specifying custom image name.

What side effects does this change have?

None.

NOTE: make pr sometimes passes but sometimes fails with:

FAIL Required test coverage of 94% not reached. Total coverage: 94.00%

This seems to be rounding error, my lines 433-434 are covered. I can add some random tests to cover lines reported like 406 and 442 for example.

Update: added some easy tests covering exceptions.

Required test coverage of 94% reached. Total coverage: 94.00%

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/build sam build command pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Oct 30, 2025
@vicheey vicheey added need-customer-response Waiting for customer response and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Mar 26, 2026
@seshubaws
Copy link
Copy Markdown
Contributor

Hello @dtsulik is this PR ready for review? Please take it out of draft mode if so

@dtsulik
Copy link
Copy Markdown
Author

dtsulik commented Mar 27, 2026

Hello @dtsulik is this PR ready for review? Please take it out of draft mode if so

Hi @seshubaws let me add a test covering this feature on weekend and I will move it forward.

@dtsulik dtsulik marked this pull request as ready for review March 28, 2026 07:59
@dtsulik dtsulik requested a review from a team as a code owner March 28, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build sam build command need-customer-response Waiting for customer response pr/external

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants