feat: custom image name support for Docker builds#8382
Open
dtsulik wants to merge 5 commits intoaws:developfrom
Open
feat: custom image name support for Docker builds#8382dtsulik wants to merge 5 commits intoaws:developfrom
dtsulik wants to merge 5 commits intoaws:developfrom
Conversation
Contributor
|
Hello @dtsulik is this PR ready for review? Please take it out of draft mode if so |
Author
Hi @seshubaws let me add a test covering this feature on weekend and I will move it forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
Currently the Docker build takes the logical resource ID from the template as the name for the image that gets built and tagged. We are able to customize the tag, but not the name. This forces the same restrictions on the image name allowed characters as the resource ID, meaning we cannot use dashes.
How does it address the issue?
Allows specifying custom image name.
What side effects does this change have?
None.
NOTE:
make prsometimes passes but sometimes fails with:FAIL Required test coverage of 94% not reached. Total coverage: 94.00%This seems to be rounding error, my lines 433-434 are covered. I can add some random tests to cover lines reported like 406 and 442 for example.
Update: added some easy tests covering exceptions.
Required test coverage of 94% reached. Total coverage: 94.00%Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.