S3 Directory Support #3304
Open
S3 Directory Support #3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detected 1 possible performance regressions:
|
jterapin
commented
Jan 14, 2026
| # * `:completed_downloads` - Number of objects successfully downloaded | ||
| # * `:failed_downloads` - Number of objects that failed to download | ||
| # * `:errors` - Array of errors for failed downloads (only present when failures occur) | ||
| def download_directory(destination, bucket:, **options) |
Contributor
Author
There was a problem hiding this comment.
I need to allow for setting a custom thread for executor here. Same goes for uploader.
| request_abort unless opts[:ignore_failure] | ||
| end | ||
|
|
||
| def process_download_queue(producer, downloader, opts) |
Contributor
Author
There was a problem hiding this comment.
In a situation where we need to raise, I decided against doing @queue_executor.kill since there might be work in-flight that hangs. It would be best to exit gracefully and the bubbles up to raise within #build_results
| raise ArgumentError, 'Invalid directory' unless Dir.exist?(source_directory) | ||
|
|
||
| uploader = FileUploader.new( | ||
| multipart_threshold: opts.delete(:multipart_threshold), |
Contributor
Author
There was a problem hiding this comment.
Self-reminder to documentation this at TransferManager#upload_directory
I need to take a look at other params available on FileUploader and FileDownloader level but I'm concerned about overlapped params if it occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds directory upload/download to Transfer Manager.
upload_directorydownload_directoryBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!