Skip to content

chore: make 'make security' fail-fast when govulncheck is absent #56

Open

Description

@millerjp

Summary

make security silently skips with an install hint if govulncheck isn't on PATH — exits 0. make check on a clean dev machine therefore passes without actually running the security gate. CI installs the tool explicitly so CI is fine, but a developer running make check before pushing gets false confidence.

Scope

Drop the soft-skip branch in the security Makefile target. Fail with the install hint if the tool is missing.

Acceptance criteria

  1. make security without govulncheck exits non-zero with a clear install instruction.
  2. CI (which installs the tool) still passes.
  3. make check behaviour on CI unchanged.

Source: go-quality agent.

Activity

  1. added this to the v1.0.1 milestone on Apr 21, 2026
  2. added
    ci/cdCI/CD pipelines and release
    P1Important, not blocking
    on Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Important, not blockingci/cdCI/CD pipelines and release

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions