Add metadata saving and registration for release assets#1424
Add metadata saving and registration for release assets#1424
Conversation
|
No TODO comments were found. |
Minimum allowed line rate is |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: actions/download-artifact@v6 | ||
| with: | ||
| pattern: metadata-* | ||
| path: metadata | ||
| merge-multiple: false |
There was a problem hiding this comment.
Download metadata from wrong workflow run
The new metadata download step relies on actions/download-artifact without a run-id, so it only searches the current release job for metadata-* artifacts. All metadata artifacts are produced by the reusable build workflows (build-executable, build-windows-installer, build-debian-package, build-macos-app) which run under different run IDs and are already exposed via artifact-run-id outputs. Without passing those run IDs here, this step will fail with “No artifacts found” before the release is created, blocking the release pipeline whenever metadata artifacts are needed.
Useful? React with 👍 / 👎.
Description
Implement functionality to save and register metadata for release assets during the release process. This includes downloading metadata, merging it, and sending it to the API for registration.
Breaking changes
None.
Fixed issues
None.