Create bugfix plugin for classes in computed keys in Firefox#16390
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Mar 31, 2024
Merged
Create bugfix plugin for classes in computed keys in Firefox#16390nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
Mar 28, 2024
Comment on lines
+167
to
+170
| overwrite: { | ||
| // TODO: Once Firefox releases the fix, write the correct version here. | ||
| firefox: undefined, | ||
| }, |
Member
Author
There was a problem hiding this comment.
For tiny browser bugs this is probably easier than having to go through compat-table.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56589 |
nicolo-ribaudo
commented
Mar 28, 2024
| async function* f() { | ||
| class A { | ||
| #x; | ||
| [(() => class {}).call()]; |
Member
Author
There was a problem hiding this comment.
We need to add .call() here to prevent Terser from undoing the work done by this plugin: terser/terser#1514
Member
There was a problem hiding this comment.
I think this is fine, because it is possible that more than just terser will do this (or may do so in the future).
Member
Author
|
I'm preparing a docs PR. |
This was referenced May 18, 2024
This was referenced May 20, 2024
This was referenced Jun 29, 2024
Open
This was referenced Jun 29, 2024
This was referenced Jun 29, 2024
Open
This was referenced Jun 30, 2024
This was referenced Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a plugin to compile
to
in Firefox, so that it doesn't throw a syntax error.