Skip to content

feat(docker): Bundle Unified Base Binary#3357

Draft
refcell wants to merge 1 commit into
mainfrom
rf/feat/bundle-unified-base-binary
Draft

feat(docker): Bundle Unified Base Binary#3357
refcell wants to merge 1 commit into
mainfrom
rf/feat/bundle-unified-base-binary

Conversation

@refcell

@refcell refcell commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

This adds the unified base node binary to the shared Rust services Docker image alongside the existing base-client compatibility entrypoint. The Docker README now documents that the image bundles base, base-consensus, basectl, and snapshotter.

@refcell refcell added feature New feature infra Area: infra labels Jun 9, 2026
@refcell refcell self-assigned this Jun 9, 2026
@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review: No issues found.

This is a clean, minimal Docker-only change. Verified:

  • The base binary target exists at bin/base/ (name = "base", described as "Unified Base node binary")
  • The client-builder stage correctly adds --bin base to the cargo build and copies the resulting binary
  • The client runtime stage correctly COPYs the binary from the builder
  • The README update accurately documents the image now bundles the unified base binary
  • The changes follow existing Dockerfile patterns consistently
  • No redundancy concern: the standalone base-builder stage (line 75-81) remains useful for the separate base runtime target (line 165-167), while the client target bundles everything together

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

✅ base-std fork tests: all 608 passed

base/base is fully in sync with the base-std spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature infra Area: infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants