Merged
Conversation
skovhus
approved these changes
Jul 15, 2023
Collaborator
skovhus
left a comment
skovhus
left a comment
There was a problem hiding this comment.
Awesome, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋, I ran into an issue when I configured Neovim as my default man pager via
export MANPAGER='nvim +Man!'. bash-language-server is resolving commands withmanbut in my casemandoes not close because it is using Neovim. This can happen for any command inMANPAGERthat doesn't exit. Below are a couple examples with different options:nvim
less
cat
vim
In this PR I am explicitly settings the pager to
catto avoid unexpected formatting.Please let me know if you have any questions or suggestions. Thanks!