add module exception #506
Merged
add module exception #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
till-m
requested changes
Sep 7, 2024
Member
till-m
left a comment
till-m
left a comment
There was a problem hiding this comment.
Could you add an exception.rst file in the docs such that we have these visible to users in the documentation?
|
|
||
| from __future__ import annotations | ||
|
|
||
| __all__ = [ |
Member
There was a problem hiding this comment.
What is the advantage of declaring the exports explicitly?
Contributor
Author
There was a problem hiding this comment.
When importing objects like from A import *, only the objects defined in __all__ should be imported.
I usually leave this in, but I'll remove it if it's not needed.
phi-friday
force-pushed
the
feat-exceptions
branch
from
64e48a8 to
f0249a5
Compare
Contributor
Author
|
Added |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
==========================================
+ Coverage 96.19% 96.21% +0.02%
==========================================
Files 10 11 +1
Lines 867 872 +5
==========================================
+ Hits 834 839 +5
Misses 33 33 ☔ View full report in Codecov by Sentry. |
till-m
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I hope to make it easier to catch errors while using
bayesian-optimization.