fix(rust): added name to the rust host_tools definition to avoid conf…#229
Closed
deblasis wants to merge 2 commits intobazel-contrib:masterfrom
Closed
fix(rust): added name to the rust host_tools definition to avoid conf…#229deblasis wants to merge 2 commits intobazel-contrib:masterfrom
deblasis wants to merge 2 commits intobazel-contrib:masterfrom
Conversation
…lict w/ rules_rust Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
Collaborator
|
Sorry for not merging this PR yet. I'm waiting for google/jsonnet#1178 to be resolved. Without a new release of jsonnet, CI for rules_jsonnet is completely busted. |
EdSchouten
added a commit
that referenced
this pull request
Jul 2, 2025
We now no longer need a nightly version of the Rust toolchain to build jrsonnet. The latest stable version works perfectly fine. However, we do still need a nightly version of the host tools to make bindeps work. Because we now also set the host tools repo name properly, we no longer need to juggle with Rust in examples/MODULE.bazel. Fixes: #224 #225 #226 #228 #229 #230 #234 #235 #236 #237 #238
EdSchouten
added a commit
that referenced
this pull request
Jul 2, 2025
We now no longer need a nightly version of the Rust toolchain to build jrsonnet. The latest stable version works perfectly fine. However, we do still need a nightly version of the host tools to make bindeps work. Because we now also set the host tools repo name properly, we no longer need to juggle with Rust in examples/MODULE.bazel. Fixes: #224 #225 #226 #228 #229 #230 #234 #235 #236 #237 #238
EdSchouten
added a commit
that referenced
this pull request
Jul 2, 2025
We now no longer need a nightly version of the Rust toolchain to build jrsonnet. The latest stable version works perfectly fine. However, we do still need a nightly version of the host tools to make bindeps work. Because we now also set the host tools repo name properly, we no longer need to juggle with Rust in examples/MODULE.bazel. Fixes: #224 #225 #226 #228 #229 #230 #234 #235 #236 #237 #238
EdSchouten
added a commit
that referenced
this pull request
Jul 2, 2025
* Upgrade all dependencies We now no longer need a nightly version of the Rust toolchain to build jrsonnet. The latest stable version works perfectly fine. However, we do still need a nightly version of the host tools to make bindeps work. Because we now also set the host tools repo name properly, we no longer need to juggle with Rust in examples/MODULE.bazel. Fixes: #224 #225 #226 #228 #229 #230 #234 #235 #236 #237 #238 * Add a workaround for aspect_bazel_lib not wrapping platform labels * Make import paths in jsonnet_to_json_test() work with modern Bazel Modern Bazel no longer includes files in the runfiles directory using the long path layout. We now only need to use short paths. Unfortunately, Bazel lacks some proper APIs for generating those in pieces, so we need to do some string substitution.
Collaborator
|
Fixed in #239. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply adds a name to the host_tools repo so that it won't conflict with the default one used within
rules_rustImportant
This will work when
rules_rusttags the next version (at the time of writing is 0.56.0) and after we bump it here.It works on my setup since I am relying on a
local_path_overrideto the latest HEAD, which includes thenameattribute CI is currently complaining about.I'll update this PR accordingly when the time comes
Fixes #228