-
Notifications
You must be signed in to change notification settings - Fork 191
Add BCR publishing workflow #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This still requires a PAT to be added as BCR_PUBLISH_TOKEN.
|
@meteorcloudy No guarantee that this actually works as there is no way for me to try it out :-) @alexeagle Did I miss anything? |
meteorcloudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
.github/workflows/publish.yaml
Outdated
| with: | ||
| tag_name: ${{ inputs.tag_name }} | ||
| # GitHub repository which is a fork of the upstream where the Pull Request will be opened. | ||
| registry_fork: bazel-contrib/bazel-central-registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, does this mean I actually need a token that has access to this fork? I will probably use the bazel-io account, so maybe this should be bazel-io/bazel-central-registry?
/cc @alexeagle @kormide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the token has to be able to push to a fork that the PR may originate from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexeagle Thanks! Can you also take a quick look at the rest of the PR?
|
I've setup BCR_PUBLISH_TOKEN using the |
meteorcloudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for helping with this! I'll merge and test the release!
|
@alexeagle @kormide Looks like attest step failed at There is no clear error message, can you take a look what went wrong? |
|
Hmm looks like it's |
|
FYI, bazelbuild rules owners: rules_cc: @pzembrod In case you also want to adopt the new reusable workflows for publishing to BCR with attestations, you can see this PR as an example, the Context: |
|
This is great. Thanks, @fmeum and @meteorcloudy! |
Copybara Import from #441 BEGIN_PUBLIC Support publish-to-bcr workflow with attestations (#441) Similar to bazelbuild/bazel-skylib#581 Closes #441 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#441 from meteorcloudy:release d399c29 PiperOrigin-RevId: 783256391 Change-Id: I4ccd53589076c948d34558c307d0213f5110bf2c
This still requires a PAT to be added as BCR_PUBLISH_TOKEN.