Flip incompatible_enable_cc_toolchain_resolution#16252
Closed
comius wants to merge 16 commits intobazelbuild:masterfrom
Closed
Flip incompatible_enable_cc_toolchain_resolution#16252comius wants to merge 16 commits intobazelbuild:masterfrom
comius wants to merge 16 commits intobazelbuild:masterfrom
Conversation
lberki
approved these changes
Sep 12, 2022
Contributor
lberki
left a comment
lberki
left a comment
There was a problem hiding this comment.
This is great. I mean, it will be great when it sticks, but merging this pull request is a necessary part of the path for getting there :)
comius
force-pushed
the
flip-cc_toolchain_resolution
branch
from
df5b46d to
a4c82eb
Compare
comius
force-pushed
the
flip-cc_toolchain_resolution
branch
from
6a8c83b to
13f5ea6
Compare
Contributor
Author
|
Downstream tests: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2641#01835443-ca23-4d89-b700-dd2ef89c8f7a Failures:
|
comius
changed the title
Contributor
Author
|
Failing test needs rules_cc 0.0.2 on bzlmod repository. |
Member
|
You can also view the broken downstream project here:
|
ShreeM01
added
team-Rules-CPP
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
RELNOTES[INC]: Flip incompatible_enable_cc_toolchain_resolution (bazelbuild#7260) Closes bazelbuild#16252. PiperOrigin-RevId: 476058407 Change-Id: I6ceb9cd306e0eeed61cb1ff8cd9804d26988d22d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELNOTES[INC]: Flip incompatible_enable_cc_toolchain_resolution (#7260)