encourage separate .bzl files for separate symbols#28070
Open
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
Open
encourage separate .bzl files for separate symbols#28070benjaminp wants to merge 1 commit intobazelbuild:masterfrom
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
Conversation
According to https://docs.google.com/document/d/1L1JFgjpZ7SrBinb24DC_5nTIELeYDacikcme-YcA7xs/edit?tab=t.0#heading=h.cy0m49ne5key, defs.bzl is legacy. So, don't advise creating one in new rule sets.
github-actions
bot
added
team-Documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for deploying Bazel rules to recommend using separate .bzl files for each symbol, instead of a single defs.bzl file. This change aligns with modern Bazel best practices for better granularity and modularity. The changes in site/en/rules/deploying.md are clear and accurately reflect this new recommendation. The pull request improves the documentation and promotes better rule-writing practices.
iancha1992
added
the
team-OSS
Member
|
@pzembrod Can you take a look? |
meteorcloudy
added
team-Rules-API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://docs.google.com/document/d/1L1JFgjpZ7SrBinb24DC_5nTIELeYDacikcme-YcA7xs/edit?tab=t.0#heading=h.cy0m49ne5key, defs.bzl is legacy. So, don't advise creating one in new rule sets.