Consistently use regular inheritance in StarlarkInt#28079
Open
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Open
Consistently use regular inheritance in StarlarkInt#28079fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Previously this class mixed regular method overrides with `instanceof` dispatch. Also seal the class hierarchy.
github-actions
bot
added
the
awaiting-review
iancha1992
added
team-Starlark-Interpreter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this class mixed regular method overrides with manual
instanceofdispatch, which resulted in a number of redundanttoBigInteger()calls and generally made it harder to follow the different cases.