Merged
Conversation
From Bazel 5 onwards, the keywords "stamp, stamp, stamp, stamp_inputs, and tag" became obsolete. Removing them.
uajith
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
removing obsolete keywords
linzhp
approved these changes
May 5, 2022
Collaborator
linzhp
left a comment
linzhp
left a comment
There was a problem hiding this comment.
tests passed on Uber's internal repo
Contributor
Author
|
@linzhp , |
Collaborator
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
From Bazel 5 onwards, the keywords "stamp, stamp, stamp, stamp_inputs, and tag" became obsolete. Removing them.
@uajith , can you elaborate what you mean by obsolete? I would like to pull the This broke when trying to upgrade to 0.25.0. |
jacobmou
added a commit
to jacobmou/rules_docker
that referenced
this pull request
Apr 19, 2023
This reverts commit 0768e1b. In the original patch bazelbuild#2077, `tag` and `stamp_input` fields of PushInfo were removed with the assumption that they become obsolete since bazel 5.0. However, bazel itself doesn't control our customized `PushInfo` provider. We have some downstream rules that are relying on these field and would like to keep using them in latest version of rules_docker.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Bazel 5 onwards, the keywords "stamp, stamp, stamp, stamp_inputs, and tag" became obsolete. Removing them.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information