Conversation
|
Would be great also to update yargs-parser https://github.com/yargs/yargs-parser/releases/tag/yargs-parser-v22.0.0 |
|
Perhaps |
|
Looks like this can be uncommented: https://github.com/bcoe/c8/blob/main/lib/parse-args.js#L176-L187 |
|
to support that, yargs 17 has an issue with node 25.7 (also see #581) which is fixed in yargs 18. do please update that dependecy file:///home/runner/work/SFMC-SDK/SFMC-SDK/node_modules/yargs/yargs:3 ReferenceError: require is not defined in ES module scope, you can use import instead Node.js v25.7.0 |
c8 depends on yargs ^17 which breaks on Node 25 due to CJS/ESM interop changes. Override yargs to ^18 (ESM-first) until c8 updates its dependency (bcoe/c8#578). Also restores node latest to the test matrix alongside 20 and 22. Signed-off-by: Tomer Figenblat <tomer@figenblat.com>
c8 depends on yargs ^17 which breaks on Node 25 due to CJS/ESM interop changes. Override yargs to ^18 (ESM-first) until c8 updates its dependency (bcoe/c8#578). Also restores node latest to the test matrix alongside 20 and 22. Signed-off-by: Tomer Figenblat <tomer@figenblat.com>
* fix: override yargs to v18 for Node 25 compatibility c8 depends on yargs ^17 which breaks on Node 25 due to CJS/ESM interop changes. Override yargs to ^18 (ESM-first) until c8 updates its dependency (bcoe/c8#578). Also restores node latest to the test matrix alongside 20 and 22. Signed-off-by: Tomer Figenblat <tomer@figenblat.com> * chore: bump minimum engines to node >= 20 and npm >= 10 yargs 18 requires Node >= 20.19.0. Node 18 is EOL since April 2025. Signed-off-by: Tomer Figenblat <tomer@figenblat.com> --------- Signed-off-by: Tomer Figenblat <tomer@figenblat.com>
Now that we've bumped the major due to a recent CVE, might as well update yargs to version with less build steps.