Normalize Zip Entry Date

[cooper-grc]

Summary by cubic

Normalized zip entry dates to 1980-01-01 local midnight for deterministic archives and stable hashes. Files now use new Date('1980-01-01T00:00:00'); tests verify DOS timestamp consistency across timezones, confirm UTC-string drift, and were cleaned up.

^{Written for commit 17ff164. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="lib/sync.ts">

<violation number="1" location="lib/sync.ts:299">
P2: Using `new Date(0)` sets ZIP entry timestamps to 1970, which is before the ZIP format’s minimum supported date (1980). Some ZIP tools reject or clamp these timestamps, so this can produce archives that aren’t portable. Consider normalizing to a supported deterministic date such as 1980-01-01.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="lib/sync.ts">

<violation number="1" location="lib/sync.ts:299">
P2: Using a timezone-less date string makes the ZIP entry timestamp depend on the local timezone, which breaks deterministic hashing across machines. Use an explicit UTC timestamp instead.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/sync.test.ts">

<violation number="1" location="tests/sync.test.ts:340">
P3: The test depends on a transitive/internal module (`compress-commons/lib/archivers/zip/util`) without declaring `compress-commons` as a dependency. This is brittle and can break when dependency layouts change (e.g., pnpm or archiver updates). Consider adding `compress-commons` as a devDependency or using a supported public API.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}