Codex/issue 2376 preserve self closing tags#2452
Open
SarthakDudhe wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2376 by adding a new HTML option, preserve_self_closing_tags, that keeps the no-space self-closing form like
and <path .../> instead of normalizing it to
.
What changed:
Added preserve_self_closing_tags to js/src/html/options.js
Updated the HTML tag-close printer in js/src/html/beautifier.js so it skips inserting the extra space before /> when this option is enabled
Registered the new CLI option in js/src/cli.js
Documented the option in README.md
Added regression coverage in test/data/html/tests.js
Behavior now:
Default behavior stays the same, so
still formats as
With preserve_self_closing_tags=true, the formatter keeps
as
The same applies to SVG-style self-closing tags like
Validation:
Ran node test/generate-tests.js
Verified both HTML and SVG examples locally