Skip to content

use Number.isNaN as it's more robust #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
not-night-but wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use Number.isNaN as it's more robust #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/modules/Format/defaults/formatters/money.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default function(cell, formatterParams, onRendered){
var after = !!formatterParams.symbolAfter;
var precision = typeof formatterParams.precision !== "undefined" ? formatterParams.precision : 2;

if(isNaN(floatVal)){
if(Number.isNaN(floatVal)){
return this.emptyToSpace(this.sanitizeHTML(cell.getValue()));
}

Expand All @@ -34,4 +34,4 @@ export default function(cell, formatterParams, onRendered){
}

return after ? sign + integer + decimal + symbol : sign + symbol + integer + decimal;
};
};
4 changes: 2 additions & 2 deletions src/js/modules/Format/defaults/formatters/star.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function(cell, formatterParams, onRendered){
star.setAttribute("xml:space", "preserve");
star.style.padding = "0 1px";

value = value && !isNaN(value) ? parseInt(value) : 0;
value = value && !Number.isNaN(value) ? parseInt(value) : 0;

value = Math.max(0, Math.min(value, maxStars));

Expand All @@ -35,4 +35,4 @@ export default function(cell, formatterParams, onRendered){
element.setAttribute("aria-label", value);

return stars;
};
};
4 changes: 2 additions & 2 deletions src/js/modules/Format/defaults/formatters/traffic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default function(cell, formatterParams, onRendered){
color = "#666666",
percent, percentValue;

if(isNaN(value) || typeof cell.getValue() === "undefined"){
if(Number.isNaN(value) || typeof cell.getValue() === "undefined"){
return;
}

Expand Down Expand Up @@ -44,4 +44,4 @@ export default function(cell, formatterParams, onRendered){
el.style.backgroundColor = color;

return el;
};
};