Correct bootstrap for PySide 6 apps#2241
Merged
freakboy3742 merged 5 commits intobeeware:mainfrom Apr 17, 2025
Merged
Conversation
4 tasks
rmartin16
reviewed
Apr 17, 2025
changes/2240.removal.rst
Outdated
| @@ -0,0 +1 @@ | |||
| If you have a Pyside6 app deployed to macOS, you must add ``min_os_version = "12.0"`` to your macOS project configuration. As of PySide 6.8.0, PySide6 macOS wheels are tagged with a minimum supported macOS version of 12.0. Previously, Briefcase would install the macOS 12 wheel, but the Briefcase app would declare itself as supporting macOS 11. This would cause errors if the app was run on macOS 11. Briefcase will no longer install macOS wheels that are incompatible with the minimum OS version declared by the app (11.0 by default). The additional ``min_os_version`` configuration option is now required to allow Briefcase to resolve the installation of PySide6 wheels. | |||
Member
There was a problem hiding this comment.
Suggested change
| If you have a Pyside6 app deployed to macOS, you must add ``min_os_version = "12.0"`` to your macOS project configuration. As of PySide 6.8.0, PySide6 macOS wheels are tagged with a minimum supported macOS version of 12.0. Previously, Briefcase would install the macOS 12 wheel, but the Briefcase app would declare itself as supporting macOS 11. This would cause errors if the app was run on macOS 11. Briefcase will no longer install macOS wheels that are incompatible with the minimum OS version declared by the app (11.0 by default). The additional ``min_os_version`` configuration option is now required to allow Briefcase to resolve the installation of PySide6 wheels. | |
| If you have a PySide6 app deployed to macOS, you must add ``min_os_version = "12.0"`` to your macOS project configuration. As of PySide 6.8.0, PySide6 macOS wheels are tagged with a minimum supported macOS version of 12.0. Previously, Briefcase would install the macOS 12 wheel, but the Briefcase app would declare itself as supporting macOS 11. This would cause errors if the app was run on macOS 11. Briefcase will no longer install macOS wheels that are incompatible with the minimum OS version declared by the app (11.0 by default). The additional ``min_os_version`` configuration option is now required to allow Briefcase to resolve the installation of PySide6 wheels. |
Comment on lines
60
to
66
| def pyproject_table_macOS(self): | ||
| return """\ | ||
| universal_build = true | ||
| min_os_version = "12.0" | ||
| requires = [ | ||
| "std-nslog~=1.0.3", | ||
| ] |
Member
There was a problem hiding this comment.
Think it's worth a comment explaining why macOS 11 isn't supported?
freakboy3742
force-pushed
the
pyside-macos-12
branch
from
311a4fc to
cdee0db
Compare
freakboy3742
force-pushed
the
pyside-macos-12
branch
from
328351e to
531b6fe
Compare
4 tasks
rmartin16
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the minimum PySide version to 6.8.0, and set a macOS minimum version for PySide apps.
This is required because PySide 6.8.0 is the first version to support Python 3.13, but macOS wheels for PySide 6.8+ are tagged
macosx_12_0_universal2. This means they won't work on macOS 11.#2239 exposed this because it started correctly enforcing the minimum macOS version when installing wheels, preventing installation on Python3.13 (where the only available wheels are tagged
macosx_12_0.beeware/briefcase-macOS-app-template#78 and beeware/briefcase-macOS-Xcode-template#78 have been generated to verify that the changes to the bootstrap actually work.
Fixes #2240.
PR Checklist: