Conversation
veged
requested changes
Oct 24, 2016
Member
veged
left a comment
veged
left a comment
There was a problem hiding this comment.
this block supposed to use in "vanilla.js" runtime that lacks document object — so let's do the check in more safe cross-engine way
dfilatov
reviewed
Oct 24, 2016
| identify = function(obj) { | ||
| if((typeof obj === 'object' && obj !== null) || typeof obj === 'function') { | ||
| var key = 'uniqueID' in obj? | ||
| var key = 'uniqueID' in obj && obj !== document ? |
Member
There was a problem hiding this comment.
I think there's a better way:
var key;
if('uniqueID' in obj) {
obj === global.document && (obj = obj.documentElement); // global should point to this.global inside module closure
key = 'uniqueID';
} else {
key = expando;
}
Member
There was a problem hiding this comment.
As a bonus, you won't have to check browser environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1440