Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Helm-configurable toggle to enable “model eager download” behavior during S3-backed image builds, wiring the setting from chart values into the controller’s bento-image-builder invocation.
Changes:
- Introduces
global.modelEagerDownloadin theyatai-image-builderHelm values. - Exposes the value as
CONTAINER_IMAGE_MODEL_EAGER_DOWNLOADvia the chart’s env Secret. - Adds a Go env getter and conditionally appends
--model-eager-downloadto the S3 image builder command flags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| helm/yatai-image-builder/values.yaml | Adds a configurable chart value to control model eager download behavior. |
| helm/yatai-image-builder/templates/secret-env.yaml | Plumbs the new value into an env var consumed by the controller. |
| controllers/resources/bentorequest_controller.go | Reads the env var and conditionally adds the corresponding CLI flag for S3 image builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xianml
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.