fix: correct subnormal float/double decode exponent#318
Open
rophy wants to merge 1 commit intobersler:masterfrom
Open
fix: correct subnormal float/double decode exponent#318rophy wants to merge 1 commit intobersler:masterfrom
rophy wants to merge 1 commit intobersler:masterfrom
Conversation
IEEE 754 subnormals use exponent 1-bias, not 0-bias. OLR used 0-bias, producing half the correct value (e.g. 7e-46 instead of 1.4e-45).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IEEE 754 subnormal (denormalized) values are decoded with the wrong exponent,
producing approximately half the correct value.
For subnormals (exponent field == 0), the effective exponent should be
1 - bias,not
0 - bias. The current code falls through without adjusting the exponent,resulting in values shifted by a factor of 2.
Example
BINARY_FLOAT
1.401298e-45(smallest positive subnormal) decodes as7.006492e-46.Fix
Set
exponent = 1before subtracting the bias in the subnormal path, for bothpositive and negative cases of
decodeFloat()anddecodeDouble().Test
Standalone test to reproduce and verify: