fix: prevent HTML injection in Svelte component generation and remove redundant code#12
Merged
Bekacru merged 1 commit intobetter-auth:mainfrom Apr 2, 2026
Conversation
… redundant code - Fix HTML injection vulnerability in generateSvelteComponent where className was directly inserted into HTML attributes without escaping quotes - Remove redundant null check in getIconPrefix (split() always returns string) - Remove unused existingName field from addIconToFile return type Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed three issues in the codebase:
1. Security Issue - HTML Injection in Svelte Component Generation
In
src/project-sync.ts, thegenerateSvelteComponentfunction directly inserts theclassNameparameter into HTML attributes without proper escaping.Before:
After:
Impact: If a user passes a
classNamecontaining double quotes (e.g.,class-"with"-quotes), it would break the generated HTML structure.2. Removed Redundant Null Check
In
src/icon-utils.ts, thegetIconPrefixfunction had an unnecessary null check sincesplit(":")[0]always returns a string.3. Removed Unused Return Field
In
src/project-sync.ts, theexistingNamefield inaddIconToFile's return type was redundant withcomponentNameand was never used.Test plan