Test: random string distribution bias#6
Closed
danielgavrilov wants to merge 1 commit intobetter-auth:mainfrom
Closed
Test: random string distribution bias#6danielgavrilov wants to merge 1 commit intobetter-auth:mainfrom
danielgavrilov wants to merge 1 commit intobetter-auth:mainfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The random string generator is using a naive method and has a bias. It's probably best to use a library for this (like nanoid) but up to you how you'd like to handle it (I'm not sure if nanoid supports all the environments you need to support).
I have added some (Claude-generated) chi-squared distribution tests to demonstrate the bias (the tests pass when using nanoid).
To switch to nanoid:
+import { customAlphabet } from "nanoid"