Skip to content

Add Typing of returns #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imadaboulhouda wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Typing of returns #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const zeroRegex = /(?:[0]{1,2}[:-]){5}[0]{1,2}/
* Get the first proper MAC address
* @param iface If provided, restrict MAC address fetching to this interface
*/
export default function getMAC(iface?: string): string {
export default function getMAC(iface?: string): string| Error {
const list = networkInterfaces()
if (iface) {
const parts = list[iface]
Expand All @@ -21,7 +21,7 @@ export default function getMAC(iface?: string): string {
}
throw new Error(`interface ${iface} had no valid mac addresses`)
} else {
for (const [key, parts] of Object.entries(list)) {
for (const [_, parts] of Object.entries(list)) {
// for some reason beyond me, this is needed to satisfy typescript
// fix https://github.com/bevry/getmac/issues/100
if (!parts) continue
Expand All @@ -36,6 +36,6 @@ export default function getMAC(iface?: string): string {
}

/** Check if the input is a valid MAC address */
export function isMAC(macAddress: string) {
export function isMAC(macAddress: string):boolean {
return macRegex.test(macAddress)
}