[Merged by Bors] - automatically resize examples to canvas parent#429
Closed
mockersf wants to merge 2 commits intobevyengine:masterfrom
mockersf:fix-wasm-button-shift
Closed
[Merged by Bors] - automatically resize examples to canvas parent#429mockersf wants to merge 2 commits intobevyengine:masterfrom mockersf:fix-wasm-button-shift
mockersf wants to merge 2 commits intobevyengine:masterfrom
mockersf:fix-wasm-button-shift
Conversation
alice-i-cecile
approved these changes
Aug 2, 2022
Contributor
|
I think the css should stay there. When loading the example is larger and gets resized once loaded
If I revert the css change but keep the bevy fix it works correctly. |
IceSentry
approved these changes
Aug 5, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
## Objective Fixes bevyengine/bevy#4963 Issue is not in Bevy but on CSS of the page to resize the canvas ## Solution Use the new option from Bevy 0.8 to resize canvas to parent
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes bevyengine/bevy#4963
Issue is not in Bevy but on CSS of the page to resize the canvas
Solution
Use the new option from Bevy 0.8 to resize canvas to parent