ImageNode measure func fixes and allow drawing inside border and padding#24154
Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom May 6, 2026
Merged
ImageNode measure func fixes and allow drawing inside border and padding#24154alice-i-cecile merged 5 commits intobevyengine:mainfrom
ImageNode measure func fixes and allow drawing inside border and padding#24154alice-i-cecile merged 5 commits intobevyengine:mainfrom
Conversation
…o be used with `ImageNode`.
…testbed slice scene.
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
viridia
approved these changes
May 6, 2026
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
M-Deliberate-Rendering-Change
alice-i-cecile
approved these changes
May 6, 2026
alice-i-cecile
added
the
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Allowing drawing with
ImageNodeinside the border and padding boxes of a UI node.Fix a lot of image measurement and aspect ratio issues.
Fixes #24150
Solution
Renamed
OverflowClipMarginBoxtoVisualBox.Added a
visual_box: VisualBoxfield toImageNode.Use the size of the selected node region in image rendering.
Fixed the bugs with the
ImageNodemeasure func.Testing
Added many more cases to
testbed_ui'simageandslicescenes:Showcase