Await futures in progress checker #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvaara
commented
Sep 14, 2024
hvaara
changed the title
Contributor
Author
This sentence from the description is wrong and based on logic from a prior commit. The current implementation awaits the thread instead of checking every second. A warning is displayed every 240 seconds with no progress. |
Contributor
Author
|
Looks like this got overwritten in main. I'll open another PR to reintroduce it. |
hvaara
added a commit
to hvaara/bigcodebench
that referenced
this pull request
Feb 20, 2025
hvaara
added a commit
to hvaara/bigcodebench
that referenced
this pull request
Feb 20, 2025
terryyz
added a commit
that referenced
this pull request
Feb 20, 2025
Reintroduce progress checker from #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the progress checker would pause for 240 seconds, causing the program to potentially wait that long after all evaluations were complete.
This PR changes the logic so that the progress checker now checks for updates every second, but only displays a warning if no progress has been made in the past 240 seconds. Once all tasks are finished, the thread will terminate.
Fixes #42