Make bodyContains return true for nested shadow roots#3034
Merged
Conversation
alexpetros
added
the
ready for review
4 tasks
This fixes an issues in which `bodyContains()` would incorrectly return false for nested shadow roots.
alexpetros
force-pushed
the
shadow-root-body-true
branch
from
9681057 to
66b2740
Compare
Open
4 tasks
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issues in which
bodyContains()would incorrectly return false for nested shadow roots.Replaces #2532
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded