Skip to content

REFACTOR: make multiband likelihood call Interferometer.get_detector_response#847

Merged
ColmTalbot merged 3 commits into
mainfrom
simplify-multiband-response
Jan 28, 2026
Merged

REFACTOR: make multiband likelihood call Interferometer.get_detector_response#847
ColmTalbot merged 3 commits into
mainfrom
simplify-multiband-response

Conversation

@ColmTalbot

Copy link
Copy Markdown
Collaborator

See https://git.ligo.org/lscsoft/bilby/-/merge_requests/1379

I think this has a conflict with #842.

Based on ongoing discussion about implementing different detector responses, it would be nice for the likelihoods to all access the response functions uniformly. The MB likelihood currently has an almost verbatim copy of the Inteferometer.get_detector_response method. This MR provides a minimal change to be able to directly call that method.…response

@mj-will

mj-will commented Nov 1, 2024

Copy link
Copy Markdown
Collaborator

#842 is merged now, so hopefully the conflicts can be resolved.

@ColmTalbot

Copy link
Copy Markdown
Collaborator Author

This will actually need more extensive changes. I think it would require moving the beam_pattern_reference_time to the Interferometer. I think this would make sense as a change, possibly as another optional argument or an attribute that needs to be manually set, e.g., by the likelihood classes. I'll mark this as draft for now.

@ColmTalbot

Copy link
Copy Markdown
Collaborator Author

@SMorisaki I can't request a review from you, but please can you review this?

@ColmTalbot ColmTalbot marked this pull request as draft November 14, 2024 15:56
@mj-will mj-will modified the milestones: 2.4.1, 2.5.0 Nov 14, 2024
@mj-will mj-will requested a review from SMorisaki January 15, 2025 14:48
@mj-will

mj-will commented Jan 22, 2025

Copy link
Copy Markdown
Collaborator

@ColmTalbot @SMorisaki is this in a state where we can get it into the next release?

@mj-will mj-will removed this from the 2.5.0 milestone Jan 23, 2025
@ColmTalbot ColmTalbot marked this pull request as ready for review February 3, 2025 19:20
@ColmTalbot ColmTalbot force-pushed the simplify-multiband-response branch from 025c01f to 262d009 Compare November 5, 2025 14:41

@mj-will mj-will left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I've checked and AFAICT it's apply the exact same operations.

This has reminded me we don't have great tests for the mutliband likelihood so it would be great if we could add more in future.

Also, my might want to flag this change to reviewers since it will impact a part of the code that is used for some production analyses.

@mj-will mj-will added this to the 2.8.0 milestone Jan 28, 2026
@mj-will mj-will requested a review from a team January 28, 2026 10:17

@GregoryAshton GregoryAshton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me.

@ColmTalbot ColmTalbot added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 79e2fae Jan 28, 2026
13 checks passed
@ColmTalbot ColmTalbot deleted the simplify-multiband-response branch January 28, 2026 16:23
noahewolfe pushed a commit to noahewolfe/bilby that referenced this pull request Feb 11, 2026
…response (bilby-dev#847)

* REFACTOR: make multiband likelihood call Interferometer.get_detector_response

* FEAT: add reference time to interferometers

* BUH: fix error from rebase
mj-will pushed a commit to mj-will/bilby that referenced this pull request Feb 19, 2026
…response (bilby-dev#847)

* REFACTOR: make multiband likelihood call Interferometer.get_detector_response

* FEAT: add reference time to interferometers

* BUH: fix error from rebase
fgittins pushed a commit to fgittins/bilby that referenced this pull request Mar 5, 2026
…response (bilby-dev#847)

* REFACTOR: make multiband likelihood call Interferometer.get_detector_response

* FEAT: add reference time to interferometers

* BUH: fix error from rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants