Skip to content

Added non-root user to docker images.#967

Merged
binwiederhier merged 2 commits into
binwiederhier:mainfrom
arahja:add_non-root_user_to_containers
Mar 7, 2024
Merged

Added non-root user to docker images.#967
binwiederhier merged 2 commits into
binwiederhier:mainfrom
arahja:add_non-root_user_to_containers

Conversation

@arahja

@arahja arahja commented Nov 30, 2023

Copy link
Copy Markdown
Contributor

Added non-root user to docker images.
This gives you the ability to run ntfy as a non-root user. resolves #966

@binwiederhier binwiederhier merged commit f2e600d into binwiederhier:main Mar 7, 2024
@binwiederhier

Copy link
Copy Markdown
Owner

Thanks

@binwiederhier

Copy link
Copy Markdown
Owner

I couldn't get this to build so I had to revert it. https://github.com/binwiederhier/ntfy/actions/runs/8195110634/job/22412872174

Feel free to open another PR with a fix for this. Try building via make release-snapshot to see if it would build o Github

@arahja

arahja commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

Sounds good, I will rework this PR.

@arahja

arahja commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

@binwiederhier I ran the make release-snapshot build command as suggested. I was able to reproduce locally. I worked around the issue by using the full path for the adduser command. There seems to be a slight variance between the linux/arm/v7/alpine and the linux/amd64/alpine images related to the "$PATH" variable. The new PR is #1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add non-root user to ntfy container images.

2 participants