doc: fix broken Transifex URLs across release notes and config#1231
doc: fix broken Transifex URLs across release notes and config#1231achow101 merged 2 commits intobitcoin-core:masterfrom
Conversation
hodlinator
left a comment
hodlinator
left a comment
There was a problem hiding this comment.
ACK b4e8e12
Same file changes as in #1228 (review).
There was a problem hiding this comment.
The replacements of
- https://www.transifex.com/bitcoin/bitcoin/
↦ https://explore.transifex.com/bitcoin/bitcoin/ - https://explore.transifex.com/projects/p/bitcoin/
↦ https://explore.transifex.com/bitcoin/bitcoin/
Look good to me.
I think the transifex_url variable: https://www.transifex.com/bitcoincore/bitcoincoreorg should point at the website translation instructions instead. It should perhaps also be renamed as the website doesn’t use transifex.
| title: Bitcoin Core | ||
| url: https://bitcoincore.org | ||
| transifex_url: https://www.transifex.com/bitcoincore/bitcoincoreorg | ||
| transifex_url: https://explore.transifex.com/bitcoin/bitcoin/ |
There was a problem hiding this comment.
My review stumbled over this replacement again. The original link is 404. I can find a "bitcoincore" organisation on Transifex, but it has no projects in it. It looks like the previously linked project was deleted in 2019.
It seems to me that the intent for this variable was to link to the website translation project rather than the client software translation project, but the website doesn’t use Transifex (and never has?). So, I suspect that this link has always been broken.
From a quick grep in the website code, it appears that the variable transifex_url is only used in _includes/istranslated.html for a "not translated" macro.
Assuming my read is right, this variable could be renamed to translation_url (here and in _includes/istranslated.html) and should link instead to the translation instructions for the website:
| transifex_url: https://explore.transifex.com/bitcoin/bitcoin/ | |
| translation_url: https://github.com/bitcoin-core/bitcoincore.org/blob/master/CONTRIBUTING.md#translation-process |
There was a problem hiding this comment.
You're right, this was for the website project, not Bitcoin Core's. I grepped the repo and transifex_url is only defined in _config.yml — it's not referenced anywhere else. istranslated.html doesn't exist in _includes/ either. Looks like dead code.
Happy to rename it to translation_url pointing at the CONTRIBUTING.md translation process like you suggested, or just remove the variable entirely. What do you think?
| title: Bitcoin Core | ||
| url: https://bitcoincore.org | ||
| transifex_url: https://www.transifex.com/bitcoincore/bitcoincoreorg | ||
| transifex_url: https://explore.transifex.com/bitcoin/bitcoin/ |
There was a problem hiding this comment.
| transifex_url: https://explore.transifex.com/bitcoin/bitcoin/ |
There was a problem hiding this comment.
Done, removed the line entirely. Confirmed there are no remaining references to transifex_url anywhere in the repo.
The only consumer (_includes/istranslated.html) was removed in e327ae7 per bitcoin-core#1166. No remaining references in the codebase.
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
I agree that the reversing the order of the two commits would be preferable, but the website code doesn’t get that enough traffic that I’d consider it important.
ACK aa807f3
|
ACK aa807f3 |
4 participants
All
transifex.comlinks in release notes and_config.ymlcurrently return 404. Transifex migrated toexplore.transifex.com.This PR updates all affected files:
www.transifex.com/projects/p/bitcoin/→explore.transifex.com/bitcoin/bitcoin/www.transifex.com/bitcoin/bitcoin/→explore.transifex.com/bitcoin/bitcoin/www.transifex.com/bitcoincore/bitcoincoreorg→explore.transifex.com/bitcoin/bitcoin/Rebased version of #1155, which has had merge conflicts since June 2025. Credit to azuchi for identifying the issue.
Verified: old URLs return HTTP 404, new URL returns HTTP 200.