Skip to content

refactor: use set_lookahead in set_lookahead_for_all#1104

Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
vladimirfomene:simplify_set_lookahead_for_all
Oct 7, 2023
Merged

refactor: use set_lookahead in set_lookahead_for_all#1104
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
vladimirfomene:simplify_set_lookahead_for_all

Conversation

@vladimirfomene
Copy link
Copy Markdown
Contributor

Description

Use set_lookahead in set_lookahead_for_all.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@vladimirfomene vladimirfomene force-pushed the simplify_set_lookahead_for_all branch from f73900e to e89cf5a Compare September 6, 2023 08:57
@vladimirfomene vladimirfomene self-assigned this Sep 12, 2023
Copy link
Copy Markdown
Contributor

@realeinherjar realeinherjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK: e89cf5a

set_lookahead does the same thing as what was replaced.

Check:

pub fn set_lookahead(&mut self, keychain: &K, lookahead: u32) {
self.lookahead.insert(keychain.clone(), lookahead);
self.replenish_lookahead(keychain);
}

Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e89cf5a

@evanlinjin evanlinjin merged commit 4a65a12 into bitcoindevkit:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants