We have:
batch_insert_unconfirmedbatch_insert_relevant_unconfirmedbatch_insert_relevant
We only need batch_insert_relevant which should have the API:
pub fn batch_insert_relevant<'t>(
&mut self,
txs: impl IntoIterator<Item = &'t Transaction>,
) -> ChangeSet<A, I::ChangeSet> {Whether they are confirmed or unconfirmed (have only anchors or last seen) is not important for doing this job. The caller can add anchors and last seen with the methods available for that. Also the documentation should make it clear why this method exists in the first place: because relevancy cannot be determined until all of the transactions have been first scanned by the indexer.
Also there is a batch_insert_unconfirmed in TxGraph that doesn't need to exist (can be achieved by a for loop).
We have:
batch_insert_unconfirmedbatch_insert_relevant_unconfirmedbatch_insert_relevantWe only need
batch_insert_relevantwhich should have the API:Whether they are confirmed or unconfirmed (have only anchors or last seen) is not important for doing this job. The caller can add anchors and last seen with the methods available for that. Also the documentation should make it clear why this method exists in the first place: because relevancy cannot be determined until all of the transactions have been first scanned by the indexer.
Also there is a
batch_insert_unconfirmedinTxGraphthat doesn't need to exist (can be achieved by a for loop).