backport (2.x): fix sqlite pre1 migration helper#415
Merged
ValuedMammal merged 1 commit intobitcoindevkit:release/2.xfrom Mar 30, 2026
Merged
Conversation
6 tasks
notmandatory
force-pushed
the
backport/fix_sqlite_pre1_migration_helper
branch
from
f3199f3 to
4d28668
Compare
oleonardolima
force-pushed
the
backport/fix_sqlite_pre1_migration_helper
branch
from
4d28668 to
c3b6591
Compare
Contributor
|
@notmandatory I rebased it and pushed c3b6591 to fix the msrv step in CI. |
3 tasks
Dmenec
reviewed
Mar 26, 2026
Dmenec
reviewed
Mar 26, 2026
Dmenec
reviewed
Mar 26, 2026
- add PreV1MigrationError - rename Pre1WalletKeychain to PreV1WalletKeychain - rename get_pre_1_wallet_keychains to get_pre_v1_wallet_keychains - change PreV1WalletKeychain::keychain to KeychainKind - change PreV1WalletKeychain::checksum to String - refactored and expanded migration tests with LLM 🤖 - style: require `rusqlite` feature in migration mod - apply `[cfg(feature = "rusqlite")] for `migration` module instead of having multiple ones in `migration.rs`.
ValuedMammal
force-pushed
the
backport/fix_sqlite_pre1_migration_helper
branch
from
c3b6591 to
fc233b2
Compare
Collaborator
|
ACK fc233b2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports #411 to the
release/2.xbranch.Notes to the reviewers
No changes to the original PR.
Changelog notice
Add get_pre_v1_wallet_keychains to assist migration from pre-1.0 bdk wallets.
Checklists
All Submissions:
just pbefore pushingNew Features: