Skip to content

Home: Fix - Keep balance change rows and totals with large font scaling - #2521

Open
cmgustavo wants to merge 1 commit into
bitpay:developfrom
cmgustavo:bug/key-overview-change-row-font-scaling-01
Open

cmgustavo wants to merge 1 commit into
bitpay:developfrom
cmgustavo:bug/key-overview-change-row-font-scaling-01

Conversation

@cmgustavo

@cmgustavo cmgustavo commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Summary

Several layout problems in the balance headers when the system font scaling is large or the amount is long: on KeyOverview the last day change row wraps with a negative change, on Home the "Some assets not charted" note pushes "Last Day" to a second line, and when the Home chart is collapsed the total is cut off next to the mini chart.

Changes

  • Percentage: add an optional maxFontSizeMultiplier prop applied to the delta, percentage and range label texts, and center the row content so it stays centered if it still wraps.
  • ChartChangeRow: cap the font scaling of the change row at 1.2x, since it is a secondary line under the balance. This fixes "Last Day" wrapping on KeyOverview with a negative change.
  • PortfolioBalance: cap the font scaling of the Home change row at 1.2x, same as ChartChangeRow, so "Last Day" stays on the same line.
  • PortfolioBalance: move the "Some assets not charted" note out of the change row and render it below the timeframe selector (right-aligned, smaller), so it no longer pushes "Last Day" to a second line.
  • BalanceHistoryChart: add an optional postTimeframeContent prop rendered under the timeframe selector and faded together with it.
  • PortfolioBalance: when the chart is collapsed, hide the "Some assets not charted" note, reserve room for the mini chart next to the total and let the amount shrink to fit (adjustsFontSizeToFit, minimum scale 0.5) so large balances are no longer cut off.

Notes

ChartChangeRow is also used by WalletDetails and the other balance charts, so they get the same 1.2x cap on the change row. adjustsFontSizeToFit can behave slightly differently on Android.

Test plan

  • Set the system font size to the largest setting and open KeyOverview with a negative last day change: the row stays on one line.
  • Same check on KeyOverview with a positive change and with hidden balances.
  • Open WalletDetails and confirm the change row looks correct.
  • On Home with the largest font size, confirm "Last Day" stays on one line under the total.
  • On Home with uncharted assets, confirm "Some assets not charted" shows below the timeframe selector, right-aligned, and opens the same modal.
  • Collapse the Home chart: the note disappears and the mini chart sits next to the total without cutting it.
  • Collapse the Home chart with a very large balance: the amount shrinks to fit instead of being cut off. Check on iOS and Android.
  • Expand the chart again and confirm the note and the timeframe selector come back.

Jira: RN-3123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant