Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several layout problems in the balance headers when the system font scaling is large or the amount is long: on KeyOverview the last day change row wraps with a negative change, on Home the "Some assets not charted" note pushes "Last Day" to a second line, and when the Home chart is collapsed the total is cut off next to the mini chart.
Changes
Percentage: add an optionalmaxFontSizeMultiplierprop applied to the delta, percentage and range label texts, and center the row content so it stays centered if it still wraps.ChartChangeRow: cap the font scaling of the change row at 1.2x, since it is a secondary line under the balance. This fixes "Last Day" wrapping on KeyOverview with a negative change.PortfolioBalance: cap the font scaling of the Home change row at 1.2x, same asChartChangeRow, so "Last Day" stays on the same line.PortfolioBalance: move the "Some assets not charted" note out of the change row and render it below the timeframe selector (right-aligned, smaller), so it no longer pushes "Last Day" to a second line.BalanceHistoryChart: add an optionalpostTimeframeContentprop rendered under the timeframe selector and faded together with it.PortfolioBalance: when the chart is collapsed, hide the "Some assets not charted" note, reserve room for the mini chart next to the total and let the amount shrink to fit (adjustsFontSizeToFit, minimum scale 0.5) so large balances are no longer cut off.Notes
ChartChangeRowis also used by WalletDetails and the other balance charts, so they get the same 1.2x cap on the change row.adjustsFontSizeToFitcan behave slightly differently on Android.Test plan
Jira: RN-3123