Skip to content

Safe Area: Fix - Remove bottom blank space on iOS screens - #2522

Open
cmgustavo wants to merge 1 commit into
bitpay:developfrom
cmgustavo:bug/screen-bottom-blank-space-01
Open

cmgustavo wants to merge 1 commit into
bitpay:developfrom
cmgustavo:bug/screen-bottom-blank-space-01

Conversation

@cmgustavo

@cmgustavo cmgustavo commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Summary

Fixes a blank strip at the bottom of iOS screens that clipped scrollable content above the home indicator (most visible when scrolling to the end of a list).

Cause

Screens use the SafeAreaView from react-native core, which on iOS pads all four edges, including the bottom one. Scroll views inside it stop ~34pt before the screen edge. The most likely trigger is the React Native 0.87 / react-native-screens 4.27 / react-native-safe-area-context 5.8 upgrade, but this was not bisected.

Changes

  • Add src/components/safe-area/SafeAreaView.tsx, a drop-in replacement for the core SafeAreaView. On iOS it uses the react-native-safe-area-context one with edges={['top', 'left', 'right']} (no bottom padding). Android keeps the core component, so its behavior is unchanged.
  • Replace the react-native SafeAreaView import with the new component in 107 files, including ScreenContainer, KeyOverview and SettingsContainer. Two modals that import it under an alias (OfferSelectorModal, SwapCryptoOfferSelectorModal) are intentionally left untouched.
  • KeyOverview: reduce the wallet list footer paddingBottom from 100 to 20.

The bottom tab bar is not modified.

Testing

  • Manually checked on iPhone 17 Pro (iOS simulator): About BitPay now scrolls fully to the last button, and the Home and Settings tabs look unchanged.
  • tsc reports no new errors in src/.
  • Not tested on Android or on devices without a home indicator.
  • Screens with a non-absolute CtaContainer at the bottom no longer get the bottom inset from the container, so it is worth a quick check of flows with a bottom button (e.g. Create Wallet).

Jira: RN-3122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant