Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a blank strip at the bottom of iOS screens that clipped scrollable content above the home indicator (most visible when scrolling to the end of a list).
Cause
Screens use the
SafeAreaViewfromreact-nativecore, which on iOS pads all four edges, including the bottom one. Scroll views inside it stop ~34pt before the screen edge. The most likely trigger is the React Native 0.87 /react-native-screens4.27 /react-native-safe-area-context5.8 upgrade, but this was not bisected.Changes
src/components/safe-area/SafeAreaView.tsx, a drop-in replacement for the coreSafeAreaView. On iOS it uses thereact-native-safe-area-contextone withedges={['top', 'left', 'right']}(no bottom padding). Android keeps the core component, so its behavior is unchanged.react-nativeSafeAreaViewimport with the new component in 107 files, includingScreenContainer,KeyOverviewandSettingsContainer. Two modals that import it under an alias (OfferSelectorModal,SwapCryptoOfferSelectorModal) are intentionally left untouched.KeyOverview: reduce the wallet list footerpaddingBottomfrom 100 to 20.The bottom tab bar is not modified.
Testing
tscreports no new errors insrc/.CtaContainerat the bottom no longer get the bottom inset from the container, so it is worth a quick check of flows with a bottom button (e.g. Create Wallet).Jira: RN-3122