Conversation
SummaryThis PR adds SimpleX benchmarking workflows to the CI pipeline, including both baseline and compilation cache variants. The implementation follows existing patterns but is missing error handling in the workflow scripts. Walkthrough
|
doomsayer13
changed the base branch from
main
to
ACI-4001-comp-cache-benchmark
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 2
| title: Install dependencies | ||
| inputs: | ||
| - content: |- | ||
| ./scripts/ios/prepare-x86_64.sh |
There was a problem hiding this comment.
🐛 Bug
The script execution lacks error handling and pipefail settings that are present in other similar workflows. This could cause the build to continue even if the preparation script fails.
🔄 Suggestion:
| ./scripts/ios/prepare-x86_64.sh | |
| set -exo pipefail | |
| ./scripts/ios/prepare-x86_64.sh |
| title: Install dependencies | ||
| inputs: | ||
| - content: |- | ||
| ./scripts/ios/prepare-x86_64.sh |
There was a problem hiding this comment.
🐛 Bug
The script execution lacks error handling and pipefail settings that are present in other similar workflows. This could cause the build to continue even if the preparation script fails.
🔄 Suggestion:
| ./scripts/ios/prepare-x86_64.sh | |
| set -exo pipefail | |
| ./scripts/ios/prepare-x86_64.sh |
2 participants
No description provided.