[PM-22523] PM-19476: Allow empty string as word separator

app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt

@@ -663,7 +663,7 @@ class GeneratorViewModel @Inject constructor(
     private suspend fun generatePassphrase(passphrase: GeneratorState.MainType.Passphrase) {
         val request = PassphraseGeneratorRequest(
             numWords = passphrase.numWords.toUByte(),
-            wordSeparator = passphrase.wordSeparator?.toString() ?: " ",
+            wordSeparator = passphrase.wordSeparator?.toString().orEmpty(),
             capitalize = passphrase.capitalize,
             includeNumber = passphrase.includeNumber,
         )

app/src/test/kotlin/com/x8bit/bitwarden/data/tools/generator/repository/util/FakeGeneratorRepository.kt

@@ -41,6 +41,8 @@ class FakeGeneratorRepository : GeneratorRepository {
 
     private var passwordGeneratorRequest: PasswordGeneratorRequest? = null
 
+    private var passphraseGeneratorRequest: PassphraseGeneratorRequest? = null
+
     private val mutablePasswordHistoryStateFlow =
         MutableStateFlow<LocalDataState<List<PasswordHistoryView>>>(LocalDataState.Loading)
 
@@ -89,6 +91,7 @@ class FakeGeneratorRepository : GeneratorRepository {
     override suspend fun generatePassphrase(
         passphraseGeneratorRequest: PassphraseGeneratorRequest,
     ): GeneratedPassphraseResult {
+        this.passphraseGeneratorRequest = passphraseGeneratorRequest
         return generatePassphraseResult
     }
 
@@ -198,4 +201,11 @@ class FakeGeneratorRepository : GeneratorRepository {
     fun assertEqualsStoredRequest(request: PasswordGeneratorRequest) {
         assertEquals(request, passwordGeneratorRequest)
     }
+
+    /**
+     * Asserts that the passed in request matches the stored request.
+     */
+    fun assertEqualsStoredRequest(request: PassphraseGeneratorRequest) {
+        assertEquals(request, passphraseGeneratorRequest)
+    }
 }

app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt

@@ -5,6 +5,7 @@ import app.cash.turbine.test
 import app.cash.turbine.turbineScope
 import com.bitwarden.core.data.repository.util.bufferedMutableSharedFlow
 import com.bitwarden.data.repository.model.Environment
+import com.bitwarden.generators.PassphraseGeneratorRequest
 import com.bitwarden.generators.PasswordGeneratorRequest
 import com.bitwarden.network.model.PolicyTypeJson
 import com.bitwarden.network.model.SyncResponseJson
@@ -2366,6 +2367,30 @@ class GeneratorViewModelTest : BaseViewModelTest() {
                 firstTimeActionManager.markCoachMarkTourCompleted(CoachMarkTourType.GENERATOR)
             }
         }
+
+    @Test
+    fun `WordSeparatorTextChange action with null separator falls back to empty string`() =
+        runTest {
+            val defaultNumWords = 3
+
+            val viewModel = createViewModel()
+            viewModel.eventFlow.test {
+                viewModel.trySendAction(
+                    GeneratorAction.MainTypeOptionSelect(GeneratorState.MainTypeOption.PASSPHRASE),
+                )
+
+                val action = GeneratorAction.MainType.Passphrase.WordSeparatorTextChange(null)
+                viewModel.trySendAction(action)
+                fakeGeneratorRepository.assertEqualsStoredRequest(
+                    PassphraseGeneratorRequest(
+                        numWords = defaultNumWords.toUByte(),
+                        wordSeparator = "",
+                        capitalize = false,
+                        includeNumber = false,
+                    ),
+                )
+            }
+        }
     //region Helper Functions
 
     @Suppress("LongParameterList")