[BWA-182] Add mTLS support for Glide image loading

[aj-rosado]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-182

📔 Objective

This PR adds mTLS (mutual TLS) support to Glide image loading.
This allows image requests to pass through Cloudflare's mTLS validation.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – ba5c83a5-bc4e-4ff9-9d1f-843aa35bbb9a

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.76%. Comparing base (3d1f469) to head (eb07a8a).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
...arden/ui/platform/glide/BitwardenAppGlideModule.kt	40.00%	6 Missing ⚠️
...n/com/bitwarden/network/ssl/SslCertificateUtils.kt	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6125      +/-   ##
==========================================
- Coverage   85.77%   85.76%   -0.02%     
==========================================
  Files         775      777       +2     
  Lines       56203    56218      +15     
  Branches     8123     8123              
==========================================
+ Hits        48207    48213       +6     
- Misses       5172     5181       +9     
  Partials     2824     2824              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

Claude finished @aj-rosado's task in 2m 42s —— View job

---

Code Review Complete

• Perform code review for PR [BWA-182] Add mTLS support for Glide image loading #6125: mTLS support for Glide image loading
• Post review findings

Summary

I've completed the code review for PR #6125, which adds mTLS (mutual TLS) support to Glide image loading. This is a well-structured PR that extracts common SSL certificate utilities into the network module and applies them to Glide for consistent mTLS handling across the application.

Key findings posted as inline comments:

• ⚠️ Unresolved thread on BitwardenAppGlideModuleTest.kt - Need to verify if tests are using JUnit 5
• Tests should include @Test annotations from org.junit.jupiter.api.Test (JUnit 5) rather than org.junit.Test (JUnit 4)

The PR properly addresses the previous review feedback by:

• Extracting common SSL logic into SslCertificateUtils.kt in the network module
• Using proper imports instead of fully-qualified paths
• Implementing the simplified loadData method with proper nullability handling

The Checkmarx security scan shows no new vulnerabilities, and the codecov report shows 66.67% patch coverage with 9 lines missing coverage (primarily in BitwardenAppGlideModule.kt and SslCertificateUtils.kt).