Support for customizing the output directory for Quack Patch#1713
Open
sig-abyreddy wants to merge 4 commits into11.4.zfrom
Open
Support for customizing the output directory for Quack Patch#1713sig-abyreddy wants to merge 4 commits into11.4.zfrom
sig-abyreddy wants to merge 4 commits into11.4.zfrom
Conversation
zahidblackduck
approved these changes
Apr 6, 2026
dterrybd
reviewed
Apr 14, 2026
| String quackPatchOutputDir = configFactory.getDetectPropertyConfiguration().getValue(DetectProperties.DETECT_QUACK_PATCH_OUTPUT); | ||
| logger.debug("Quack Patch output directory set to: {}", quackPatchOutputDir); | ||
| ComponentLocator.runQuackPatch(rapidFullResultsFile, relevantDetectorsAndFiles, llmKey, llmName, llmURL, quackPatchOutputDir); | ||
| return new QuackPatchResult(getQuackPatchOutputDirectory(new File(quackPatchOutputDir))); |
Contributor
There was a problem hiding this comment.
indentation on the return looks off from the rest of the method
dterrybd
approved these changes
Apr 14, 2026
cpottsbd
reviewed
Apr 14, 2026
| * npm detectors now allow for aliases to be used when specifying dependencies in the package.json file. | ||
| * Ivy CLI Detector, leveraging the `ivy:dependencytree` Ant task to extract direct and transitive dependencies for Ant + Ivy projects. For further information, see [Ivy (Ant) support](packagemgrs/ivy.md). | ||
| * Changed the default output directory of the Quack Patch feature to current working directory. | ||
| * Introduced a new flag `detect.quack.patch.output` to control the path for quack patch output information. If not set, the current working directory will be used as the default. |
Contributor
There was a problem hiding this comment.
Perhaps line 27 is made redundant with your line 28? (OR should it be under a "### Changed features" heading?)
Suggestion for line 28:
- Introduced the
detect.quack.patch.outputproperty to control the Quack Patch output information path. If not set, the current working directory will be used as the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for customizing the output directory for Quack Patch.
Changes,
detect.quack.patch.outputto control the path for quack patch output information. If not set, the current working directory will be used as the default.Ticket: IDETECT-5066