Skip to content

fix(mobile): name identity-link mention pills from their key - #9841

Open
brow wants to merge 14 commits into
mainfrom
mention-pill-key-names
Open

brow wants to merge 14 commits into
mainfrom
mention-pill-key-names

Conversation

@brow

@brow brow commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #9699 mention typing, fixing two identity problems found in its review.

Identity-link pills name the key they open. An edit writes each mention as an identity link, [@Name](nostr:npub1…), and every message from any client draws such a link as a pill. Mobile showed the label written in the link, so [@Wes](nostr:<mallory>) drew an ordinary @Wes pill that opened Mallory's profile, and two namesakes in an edited message both read Scout. The pill now shows the name its key resolves to in the channel (with the namesake qualifier and agent icon), as buzz-app's ProfileMention already does. The written label shows only when the key has no name on this device (no profile, directory or roster name), never a compact npub in its place. This holds whether or not the link's key is also tagged. A pill requests its key's profile when uncached, so a written label gives way to the key's name once it loads.

Edits carry no p tag, so an identity-link pill resolves its own key. In channel, thread and forum rows the pill watches that one key's channel label (with the namesake qualifier and agent icon) and requests the key's profile when it builds, so only links that actually draw a pill cost a lookup, whatever Markdown surrounds them. Inbox and search previews draw identity links the same way, taking keys from the preview pieces they render. These keys never feed the text bindings, so plain @Name text still binds only through signed tags.

Typed names group the way the text scan reads them. The composer grouped the roster by toLowerCase while the scan folds names with foldMentionLabel. With members Sam and ſam, typing @ſam sent Sam's p tag. Grouping, lookup and the send-time key qualifier now all fold, so namesakes under folding fail as ambiguous, as other namesakes already do.

Linked lookups stay current and bounded. Pills and preview rows request their keys through the profile cache's revalidation path. A name restored from the last launch is revalidated, so a renamed key's link shows its current name. A lookup that fails while offline is retried once the relay reconnects, including when the reconnect comes while that lookup is still on the wire. A key the relay says has no profile is not asked for again for five minutes, and the cache remembers at most 1,000 such keys per community. Previews keep tilde and quoted code fences literal and read blockquotes as the full message does, and load only the links on lines they draw. Editing a message folds historical names the way the scan does, so a name two tagged people share under folding seeds no chip. Rendering binds signed names by the same fold, so with signed Sam and ſam a plain @Sam stays text instead of drawing Sam's pill.

Desktop (buzz-app) already names identity-link chips from the key and needs no change.

Validation

Rows add no per-message work: message bodies are no longer scanned for links. Each drawn identity-link pill adds one label watch for its own key.

Added tests:

  • Channel page journey step: an edited message linking [@Wes] to Mallory's key draws Mallory, and two edited Scout namesakes draw distinct qualified labels, through the real channel row.
  • Channel page journey step: a link to a key with no name here keeps its written label.
  • Preview identity link: an inbox/search preview shows the key's resolved name, or the written label when unknown.
  • Preview keys: a preview loads only links it draws (not ones in code or past its line limit), including labels with brackets.

Full-app run (iOS simulator, debug build, signed in to a test community): posted a message with a spoofed identity link, a link to a key with no profile here, and a link inside inline code. The spoofed link drew the key's real name as a pill and opened that person's profile; the unknown key kept its written label; the code span stayed raw. The same message drew matching pills in search results and in the thread view.

  • Channel row loads: a row requests profiles only for links it draws as pills, not ones in a quoted code fence or an HTML comment.

  • Folded chip qualifiers: picked @Sam and @ſam chips both carry their keys on send.

  • Ambiguous typed names table: Sam and ſam in either roster order now refuse @ſam as ambiguous.

  • Restart and reconnect journey: a restored old name and an offline first lookup both resolve after the relay reconnects, on the same mounted pills, and a key with no profile is not requested again.

  • Preview fences: tilde and quoted fences keep links and Markdown literal and load no keys.

  • Overtaken lookup: a reconnect during a link's failing lookup asks once more after it settles.

  • Folded signed names: signed Sam and ſam in either tag order leave @Sam as text in the message and its preview.

  • Folded edit chips: Sam and ſam tagged in either order open as text, with no chip.

  • Non-member labels: a non-member labels the same with or without the roster shortcut, including names shaped like qualifiers.

Regressions

  • Performance: rows do no new scanning; each drawn identity-link pill adds one label watch. A non-member whose name can't collide no longer re-resolves the whole roster.
  • Mention semantics: unchanged for tagged mentions and plain text. Only identity-link pills change, from the written label to the key's resolved name.
  • Composer: names that differ only under Unicode folding (ſ/s, µ/μ, final ς/σ) are now one name when matching typed text, so a typed one between two such members asks for a pick instead of silently choosing one. Picked chips are unaffected.

An identity link's pill showed the label written in the link, so any
client could draw an ordinary @wes pill that opened someone else's
profile, and edited namesakes looked identical. Name the pill from its
key, as buzz-app does, and have message rows resolve linked keys for
labels and agent icons.

Group typed mention names by foldMentionLabel, as the text scan compares
them, so names equal under folding fail as ambiguous instead of tagging
one member.

Signed-off-by: Tom Brow <tomb@block.xyz>
@brow

brow commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T23:43:55.143131Z 1e4b374 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 5bebe8381c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

brow and others added 7 commits November 20, 2026 14:09
…previews

A linked key with no profile, directory or roster name keeps the label
written into its link instead of a compact npub. Inbox and search
previews draw identity links by destination, reference-style
definitions yield their keys, and forum cards collect keys only from
the preview they show.

Signed-off-by: Tom Brow <tomb@block.xyz>
An identity link whose key has no name here keeps its written label even
when the key is also tagged. Rows request uncached profiles for linked
keys so the key's name replaces the written label once it loads, the
link scan is memoized per body, and the send-time key qualifier groups
picked chips by folded name.

Signed-off-by: Tom Brow <tomb@block.xyz>
A nameless tagged agent's mention name is its compact npub; an identity
link to it keeps its written label, in pills and previews alike.

Signed-off-by: Tom Brow <tomb@block.xyz>
Channel rows scan inline links outside code, accepting angle-bracketed
and titled destinations and ignoring reference definitions. Inbox and
search take keys from the preview pieces they render. A real name equal
to a compact npub still names the link.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz>
Signed-off-by: Tom Brow <tomb@block.xyz>
Rows no longer scan message bodies for identity links. Under an
IdentityLinkChannel, each drawn pill watches only its own key's real
name and agent flag in the channel's names, and requests that key's
profile when it is uncached. Links inside quoted fences, HTML comments
or code never draw a pill, so they never load a profile.

The preview key collector reads the same normalized source the preview
renderer uses, so a label with brackets still loads its key.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz>
Signed-off-by: Tom Brow <tomb@block.xyz>
@brow
brow marked this pull request as ready for review November 20, 2026 23:42
@brow
brow requested a review from a team as a code owner November 20, 2026 23:42
@brow
brow enabled auto-merge (squash) November 20, 2026 23:42
@brow
brow deployed to codex-review November 20, 2026 23:42 — with GitHub Actions Active
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: 8a3912f1511a46faf30b4cef774c634529e9f2f1...92093ec1867d9dc04772caf8f346271f3eeefa0c
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

No concrete security, correctness, or reliability findings identified in the authorized PR range.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only source, history, caller, and test inspection. Builds and tests were not executed, as instructed.

Generated by Codex Security Review |
Requested by: @brow |
Workflow run

@jedwards27 jedwards27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 :bot: Jude’s code review agent — integrated review

Verdict: COMMENT — recommend request changes. Reviewed f9b18c7f3a55b5ffcef33686cd766c34257c1956..1e4b3741e2819294a6a627eccd2a5af9cf436e6a (exact head). Risk: high — the display name of a linked identity must remain bound to its key, including after restart and reconnect. The diff is mobile-only; no relay wire contract changes. Both independent review lenses and the integration pass agree on the first blocker; the product/UI lens found the second.

  1. [P2] Linked-key profile lookups skip stale restored profiles and fail to recover from a transient offline fetch. mobile/lib/features/channels/message_mention_pill.dart:199-209 and mobile/lib/features/channels/channel_identity_names_provider.dart:74-85 gate preload on cache absence, but user_cache_provider.dart:97-106,197-200 restores names as present-but-unrevalidated and only preload/get schedules their refresh. An untagged link to a renamed non-member can keep showing its former name after a cold launch; channel-backed previews have the same skip. A failed first fetch is also one-shot while the pill remains mounted (user_cache_provider.dart:268-305), so reconnect need not replace the authored fallback label. Author action: request linked keys through the cache's coalescing/revalidation path even when restored, and arrange a bounded retry on reconnect for a still-mounted pill. Add production-seam regressions for restored old name → current name and offline → online on the same mounted link, including preview where applicable.

  2. [P2] Folded names remain ambiguous only in the ordinary send path, not edit hydration. mobile/lib/features/channels/compose_bar/message_edit_sheet.dart:436-447 indexes old tagged labels and looks up mentionOccurrences results with toLowerCase(), while the scanner and this PR's composer path use foldMentionLabel. Two tagged identities named Sam and ſam can seed one arbitrary bound edit chip depending on order; saving writes a link to that key. This edit path predates the diff, but it leaves the PR's stated unified typed-name ambiguity contract broken across the shared edit flow. Author action: fold both indexing and lookup in edit hydration and test both tag orders, asserting that an ambiguous historical label binds no arbitrary key.

Behavior/contracts traced: linked nostr:npub key controls navigation; ordinary unlinked text remains gated by signed p tags. Channel labels compare against the channel roster; profile cache resets with relay config. No independent new cross-key or cross-community binding defect found in these paths. Optional performance follow-up: messagePreviewIdentityKeys scans the full content with contains before extracting a bounded preview (preview_text.dart:154-165); profile before changing it.

Validation: On a clean Mac worktree at exact head, git rev-parse HEAD, git status --porcelain, git diff --check f9b18c7f3a55b5ffcef33686cd766c34257c1956...HEAD (pass). GitHub's head checks report Mobile Checks, Android, Mobile Tests 1/3–3/3 and Flutter flake check passing. Reviewer did not run the Flutter suite or an independent native/device journey; PR author describes an iOS simulator test-community journey, not reviewer proof. Added channel-row and preview parser tests do not cover restored snapshots, reconnect, or the edit ambiguity. Verification owner: author for fixes and regression tests; reviewer/tooling for an exact-head native/product journey and independent full mobile package gate after a new head. Residual risk: thread/forum/inbox/search journeys and stale-name recovery have not been independently witnessed. Green CI does not resolve the identified defects.

This is a comment review because repository policy reserves GitHub Request Changes for humans; the recommendation is request changes until both author actions are resolved.

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Star Lord recommends fixes at 1e4b374. The inline findings cover fenced-code previews, repeat profile requests, and per-link roster resolution. Source-only review. I also confirmed the linked-profile refresh and reconnect findings in Jude’s review.

add(PreviewMedia(kind));
continue;
}
final identity = _identityMention(label, url);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 — Keep fenced examples literal in previews. _keptLines recognizes unquoted backtick fences only. An identity link inside a tilde fence or a quoted fence becomes a mention pill in Inbox and Search and queues a profile lookup. Match the full message’s code handling before classifying preview links and collecting their keys.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Fixed in e3b3d56: preview lines now recognize backtick and tilde fences, quoted or not, before classifying links or collecting their keys. Table rows cover both.

if (missing.isNotEmpty) {
Future.microtask(() {
if (ref.context.mounted) {
ref.read(userCacheProvider.notifier).preload(missing);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 — Suppress repeat lookups after a successful empty response. When a linked key has no profile, a completed batch leaves it absent from userCacheProvider. Each later preview rebuild can enqueue another request, and scrolling a full-message pill out and back can do the same. Use a bounded, scope-specific cache for successful misses while preserving retries for failed requests and allowing newly published names to appear.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Fixed in e3b3d56: the profile cache now remembers keys the relay answered with no profile, for this community scope only. Linked lookups skip those keys for 5 minutes, and the cache holds at most 1000 of them. A failed batch is not remembered, so it still retries on reconnect, and a newly published name shows up through live events or after the 5 minutes.

: ref.watch(
channelIdentityNamesProvider(channelId).select(
(names) => (
name: names.hasName(pubkey) ? names.labelFor(pubkey) : null,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 — Reuse roster lookup work across linked keys. IdentityNames.resolve builds and resolves the full roster plus the target for each distinct named nonmember. The channel scope is recreated on any profile cache update, so even an unrelated profile arrival can repeat that synchronous work for every such pill. Preserve the current naming policy while sharing roster comparison work and limiting recomputation to relevant changes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Fixed in e3b3d56: when a non-member's name can't match any member label (not a member's name, and not shaped like an owner, agent or key-suffix qualifier), it resolves without re-running the roster. Otherwise the full policy runs as before. A table test checks that both paths give the same label, for a person and for an agent.

brow and others added 2 commits November 20, 2026 16:08
Identity-link pills and preview rows now request their keys through the
profile cache's revalidation path, so a restored former name is replaced,
a failed lookup retries once the relay reconnects, and a key with no
profile is not asked for again for five minutes.

Previews keep tilde and quoted fences literal, edit hydration folds names
as the mention scan does, and a non-member whose name cannot collide skips
re-resolving the whole roster.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz>
Signed-off-by: Tom Brow <tomb@block.xyz>
@brow
brow deployed to codex-review November 21, 2026 00:21 — with GitHub Actions Active
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 21, 2026
@brow

brow commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Addressing Jude's review, in e3b3d56:

  1. Pills and preview rows now request linked keys through the profile cache's revalidation path, so a restored former name gets replaced. A batch that fails is retried once the relay reconnects. The new channel-page journey restores a snapshot with an old name and starts offline, then reconnects on the same mounted pills and checks the current names.
  2. Edit hydration now folds both the index and the lookup with foldMentionLabel. A test checks that Sam and ſam seed no chip, in both tag orders.

@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 21, 2026
brow and others added 2 commits November 20, 2026 16:27
A link to a key another lookup already had on the way skipped the
reconnect retry, so a failed batch could leave its pill on the old or
written label. Enroll it once and let the batch loader dedupe.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz>
Signed-off-by: Tom Brow <tomb@block.xyz>
An unquoted fence now ends only at an unquoted closer, so a quoted
fence line inside it stays code. A quoted fence ends when its quote does.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz>
Signed-off-by: Tom Brow <tomb@block.xyz>
@brow
brow deployed to codex-review November 21, 2026 00:38 — with GitHub Actions Active
@github-actions github-actions Bot added codex-security-review-current The posted Codex security review matches its recorded range. and removed codex-security-review-current The posted Codex security review matches its recorded range. labels Nov 21, 2026

@jedwards27 jedwards27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 :bot: Jude’s code review agent — integrated review

Verdict: COMMENT — recommend request changes. Reviewed 8a3912f1511a46faf30b4cef774c634529e9f2f1..efbd18474e0308862b97a95d8fbe2d5757c7ed48 (exact head). Risk: high: identity-link labels and historical signed mentions must not misidentify a key after reconnect or under Unicode-folded ambiguity. Mobile/client presentation and interpretation of existing signed p tags changed; no relay wire contract changed. The prior 1e4b374 review is superseded. The restored-profile, settled-offline and edit-hydration paths have been fixed on the traced routes; two author-actionable defects remain:

  1. [P2] Reconnect overtaking an in-flight linked-profile lookup still drops the retry. mobile/lib/shared/profile/user_cache_provider.dart:179–185,314–379: the connected listener calls _scheduleFetch while the key is _inFlight, so the retry is skipped. If the old request rejects afterward, finally clears _inFlight without scheduling _linkedUnanswered. A mounted pill can remain on its authored/stale label until another reconnect/remount. At this exact head, a temporary test using the production notifier held the first fetch, transitioned reconnecting→connected, then rejected it; flutter test --no-pub ... --plain-name 'review probe: reconnect before failed link flight settles' failed Expected: 2; Actual: 1. The probe was removed and the worktree restored clean. Real history can outlive the socket replacement or await the rate-limit gate (mobile/lib/shared/relay/relay_session.dart:327–353,604–671). The new needsLinkedLookup branch and passing test cover a link joining another pending preload but settle its first fetch before reconnect (user_cache_provider_test.dart:428–465); they do not cover this ordering. Author action: preserve a single reconnect retry intent until the old flight settles, then issue it; keep the reconnect-before-rejection production-seam regression.

  2. [P2] Fold-equivalent signed historical names still draw a falsely unique pill. mobile/lib/shared/mentions/mention_bindings.dart:101–103,127–132 folds occurrence matching but indexes signed names with toLowerCase(); mobile/lib/features/channels/message_content/mention_markdown.dart:44–47 looks up the lowercased raw text. With two signed identities named Sam and ſam, old unqualified @Sam draws a pill bound to Sam rather than ambiguous literal text. A temporary widget test through production MessageContent with both signed tags and onMentionTap failed its “no MessageMentionPill” assertion: one pill rendered. Although this rendering path predates the diff, this PR claims consistent folded-name resolution for send/edit while docs/mention-editor.md:81–94 forbids resolving ambiguous historical aliases by tag order. Author action: use the same fold for signed-text binding and its rendering consumers (including MessagePreview), and test both signed-tag orders in a real channel/thread/preview path asserting no key-specific pill/tap.

Non-blocking performance mismatch: messagePreviewIdentityKeys includes the maxLines + 1 overflow line (mobile/lib/features/channels/message_content/preview_text.dart:154–164,181–184), while MessagePreview clips at maxLines (message_preview.dart:77–132). A link on line three of a two-line inbox/search preview can fetch an unseen key. This is bounded to an extra logical line and negative answers are cached; it contradicts the “only drawn links” claim but is not a separate merge blocker. Suggested follow-up: exclude overflow-only keys and test that immediate boundary.

Behavior/contracts traced: linked key determines navigation and label; signed p tags gate plain text; channel and no-channel previews request linked profiles. The new pending-preload join logic works, collision-shaped non-member names retain the full resolver, and quoted/unquoted preview fences have matching-closer tests. No separate cross-community binding defect found in those traced paths.

Validation: Mac clean exact-head worktree and git diff --check 8a3912f1511a46faf30b4cef774c634529e9f2f1...HEAD passed in both lanes. Product/UI lane: just mobile-check passed and flutter test mobile/test/features/channels/message_content/preview_text_test.dart passed (52); targeted channel-row, edit and composer tests passed at the preceding head. Systems lane: new pending-preload regression passed, reconnect-order probe failed as above. Temporary probes were removed; neither lane ran the full mobile package suite or independent native iOS/VoiceOver journey. At this new head, GitHub Mobile Checks and Mobile Tests 3/3 passed; Tests 1/3–2/3, Android, Flutter flake and native Swift were pending at the last read. Prior-head mobile gates passed but do not transfer to this SHA. Verification owner: author for the two fixes and behavioral regressions; reviewer/tooling for exact-new-head native, screen-reader and full mobile journey; CI/release gate for new-head checks. Residual risk: thread/forum/inbox/search and assistive journeys have not been independently witnessed on a device.

This is one COMMENT review because repository policy reserves GitHub Request Changes for humans; recommendation: request changes until the two author actions are resolved.

brow and others added 2 commits November 20, 2026 16:46
A blockquote continues over unmarked lines and ends only at a blank
line, which also closes a fence opened inside it. The reconnect retry
test now waits on the retried request instead of a fixed delay.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz>
Signed-off-by: Tom Brow <tomb@block.xyz>
… names

A reconnect while a linked key is in flight now asks again once that
flight settles, so a failed request no longer drops the retry. Signed
historical names bind by the same fold the text scan uses, so names
that fold alike stay ambiguous plain text in messages and previews. A
preview no longer loads keys from the overflow line it never draws.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz>
Signed-off-by: Tom Brow <tomb@block.xyz>
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 21, 2026
@brow
brow deployed to codex-review November 21, 2026 00:58 — with GitHub Actions Active
@brow
brow disabled auto-merge November 21, 2026 01:01
@brow
brow enabled auto-merge (squash) November 21, 2026 01:01
@brow

brow commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Addressed in 92093ec:

  1. Reconnect overtaking an in-flight lookup: a reconnect while unanswered linked keys are in flight now records one retry intent, which reschedules them when that flight settles. Regression: a reconnect during a failing link lookup retries after it (holds the first fetch, reconnecting→connected, rejects, expects 2 requests).
  2. Fold-equivalent signed names: renderedMentionBindings and the MessageContent lookup key by foldMentionLabel, which MessagePreview shares through the same bindings. Regressions in both MessageContent and MessagePreview cover both signed-tag orders and assert no pill and no tap.
  3. Overflow line (non-blocking): messagePreviewIdentityKeys now loads only the drawn lines, with a boundary test.

Each regression fails on the previous head. The full mobile suite passes.

@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 21, 2026
@brow

brow commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Addressing Jude's review, all in 92093ec:

  1. Reconnect overtaking an in-flight linked lookup: a reconnect that finds an unanswered linked key still in flight now marks a retry, and that flight's finally asks again for whatever is still unanswered once it settles. Regression test a reconnect during a failing link lookup retries after it holds the first fetch, reconnects, rejects it, and awaits the second request.
  2. Fold-equivalent signed names: renderedMentionBindings and the message's mention lookup now key by foldMentionLabel, so signed Sam and ſam leave plain @Sam as text. Tested in both tag orders through MessageContent and MessagePreview.
  3. Overflow line (non-blocking): messagePreviewIdentityKeys now stops at the last drawn line, with a boundary test (line 2 of a 2-line preview loads, line 3 doesn't).

@brow
brow requested a review from jedwards27 November 21, 2026 01:03

This branch was successfully deployed

1 active deployment
codex-review — 92093ec1 Deployed Nov 21, 2026 by brow via Run Codex Security Review #17106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants