Create default gooseignore file when missing#6498
Conversation
mattjoyce
force-pushed
the
gooseignore-visible-defaults
branch
2 times, most recently
from
6cff713 to
26e68ed
Compare
|
love that the default is there to keep average users from messing up their secrets files, but if theyre more advanced..they have the option to edit the ignore file. |
mattjoyce
force-pushed
the
gooseignore-visible-defaults
branch
from
26e68ed to
e451223
Compare
|
Thinking about it, we can help user more. I have added some guidance into the default .gooseignore, including some other examples of files that users might unintentionally expose. |
mattjoyce
force-pushed
the
gooseignore-visible-defaults
branch
from
e451223 to
f9e6b0f
Compare
Instead of using hardcoded ignore patterns when no .gooseignore exists, automatically create a .gooseignore file with the default patterns and helpful comments showing commonly-used patterns users can uncomment. This makes the default ignore behavior discoverable and easily customizable. Signed-off-by: matt joyce <matt.joyce@gmail.com>
mattjoyce
force-pushed
the
gooseignore-visible-defaults
branch
from
f9e6b0f to
483cb90
Compare
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
seems reasonable safety feature, thanks!
* 'main' of github.com:block/goose: Create default gooseignore file when missing (#6498) fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718)
|
@mattjoyce just realized that we should probably add a default |
Done. I think .gitignore is most robust. |
4 participants
Summary
.gooseignorethe first time we need the built-in safety patterns so the defaults are visible/editable instead of hidden in code
Testing
cargo fmtcargo test -p goose-mcp test_default_patterns_when_no_ignore_files